Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: ActionMenu/Picker - add identifier to internal sp-menu for css customization #2068

Closed
1 task done
spdev3000 opened this issue Jan 21, 2022 · 2 comments
Closed
1 task done

Comments

@spdev3000
Copy link
Collaborator

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

ActionMenu, Picker

Description of the requested feature

We have seen quite difficulties to adapt and style underlying sp-menu without any additional id or class of that element. The problem is - if you’d add css styles for an sp-menu of an ActionMenu and the user opens another (not-styled) ActionMenu, those sp-menu css styles will get also applied to the new menu, as there is a short time, when both menus are both opened.
Would it be possible to add an optional parameter (data-menu-id or menuClass) to the newly created internal sp-menu in PickerBase to be used for styling or for e2e tests as css reference?

Styling use cases could include:

  • subtitles / subtext in an sp-menu-item
  • different colors
  • extended alignment of icons for multiline items

Mockups or screenshots

No response

Implementation notes or ideas

No response

@Westbrook
Copy link
Contributor

Leaking these implementation details could be prevented by moving to a <dialog>/[popup] structured API.

@najikahalsema
Copy link
Collaborator

Will be addressed by #2086

@najikahalsema najikahalsema closed this as not planned Won't fix, can't repro, duplicate, stale Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants