Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: sp-action-menu should support customizing the internal sp-menu #1831

Closed
1 task done
charlessuh opened this issue Oct 4, 2021 · 2 comments
Closed
1 task done
Labels
1.0.0 Issues that should be addressed for a 1.0 release! Component: Action Menu enhancement New feature or request Needs discussion Proposed UX or spec changes

Comments

@charlessuh
Copy link
Collaborator

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

sp-action-menu

Description of the requested feature

When using sp-action-menu, there is no way to customize the internal sp-menu that is opened. Potential use cases could be specifying a max-width, or overriding a supported CSS variable.

For example, perhaps sp-action-menu could support a menu slot:

<sp-action-menu size="m">
    <span slot="label">More Actions</span>
    <sp-menu slot="menu" style="max-width: 400px; --spectrum-listitem-m-height: 50px;">
        <sp-menu-item />
    </sp-menu>
</sp-action-menu>

Mockups or screenshots

No response

Implementation notes or ideas

No response

@charlessuh charlessuh added enhancement New feature or request triage An issue needing triage labels Oct 4, 2021
@hunterloftis hunterloftis added 1.0.0 Issues that should be addressed for a 1.0 release! Needs discussion Proposed UX or spec changes and removed triage An issue needing triage labels Oct 13, 2021
@hunterloftis
Copy link
Contributor

We should review the previous decision to remove sp-menu with @adixon-adobe

@najikahalsema
Copy link
Collaborator

Will be addressed by #2086

@najikahalsema najikahalsema closed this as not planned Won't fix, can't repro, duplicate, stale Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0.0 Issues that should be addressed for a 1.0 release! Component: Action Menu enhancement New feature or request Needs discussion Proposed UX or spec changes
Projects
None yet
Development

No branches or pull requests

3 participants