Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Overlay] Support overlaying detached elements #1540

Closed
Westbrook opened this issue Jun 14, 2021 · 0 comments · Fixed by #1588
Closed

[Overlay] Support overlaying detached elements #1540

Westbrook opened this issue Jun 14, 2021 · 0 comments · Fixed by #1588
Labels
Component: Overlay

Comments

@Westbrook
Copy link
Contributor

Expected Behaviour

Overlay.openOverlay accepts detached elements for the content argument.

Actual Behaviour

Overlay.openOverlay accepts only elements that srcElement.parentElement || srcElement.getRootNode() as "content".

cc: @kaiortmanns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Overlay
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow detached elements to be used as content for an overlay adobe/spectrum-web-components
1 participant
@Westbrook