Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Overlay] Clarify style/theme resolution/throwing in the documentation #1267

Closed
Westbrook opened this issue Mar 10, 2021 · 2 comments · Fixed by #1383
Closed

[Overlay] Clarify style/theme resolution/throwing in the documentation #1267

Westbrook opened this issue Mar 10, 2021 · 2 comments · Fixed by #1383

Comments

@Westbrook
Copy link
Contributor

Things projecting into an active-overlay element expect to benefit from either a global application of Spectrum CSS custom properties or have lived within an sp-theme scope in order to have their theme context resolve appropriately while the overlay is open, clarify this in the docs.

Styles applied to content thrown into an overlay will not be associated with that content when an overlay is open. Clarify the requirements of an encapsulated component, inline styles, or a <style> element contained in the thrown content.

cc: @aashritandon92

@Westbrook
Copy link
Contributor Author

@aashritandon92 I've added the proposed Styling section to https://westbrook-overlay-styles--spectrum-web-components.netlify.app/components/overlay-trigger does it seem clearly outline the options we discussed oh so long ago now?

@aashritandon92
Copy link
Contributor

@aashritandon92 I've added the proposed Styling section to https://westbrook-overlay-styles--spectrum-web-components.netlify.app/components/overlay-trigger does it seem clearly outline the options we discussed oh so long ago now?

It looks good to me. Thanks for adding that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants