fix: match "pointerup" listeners with "pointercancel" for full coverage

adobe · Sep 19, 2022 · 7f2ce92 · 7f2ce92
1 parent 962c3e8
commit 7f2ce92
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/packages/button/src/ButtonBase.ts b/packages/button/src/ButtonBase.ts
@@ -234,10 +234,15 @@ export class ButtonBase extends LikeAnchor(
             if (this.active) {
                 this.addEventListener('focusout', this.handleRemoveActive);
                 this.addEventListener('pointerup', this.handleRemoveActive);
+                this.addEventListener('pointercancel', this.handleRemoveActive);
                 this.addEventListener('pointerleave', this.handleRemoveActive);
             } else {
                 this.removeEventListener('focusout', this.handleRemoveActive);
                 this.removeEventListener('pointerup', this.handleRemoveActive);
+                this.removeEventListener(
+                    'pointercancel',
+                    this.handleRemoveActive
+                );
                 this.removeEventListener(
                     'pointerleave',
                     this.handleRemoveActive

diff --git a/packages/card/src/Card.ts b/packages/card/src/Card.ts
@@ -198,8 +198,10 @@ export class Card extends LikeAnchor(
                 this.click();
             }
             this.removeEventListener('pointerup', handleEnd);
+            this.removeEventListener('pointercancel', handleEnd);
         };
         this.addEventListener('pointerup', handleEnd);
+        this.addEventListener('pointercancel', handleEnd);
     }
 
     protected get renderHeading(): TemplateResult {

diff --git a/packages/menu/src/MenuItem.ts b/packages/menu/src/MenuItem.ts
@@ -467,12 +467,17 @@ export class MenuItem extends LikeAnchor(Focusable) {
             if (this.active) {
                 this.addEventListener('pointerup', this.handleRemoveActive);
                 this.addEventListener('pointerleave', this.handleRemoveActive);
+                this.addEventListener('pointercancel', this.handleRemoveActive);
             } else {
                 this.removeEventListener('pointerup', this.handleRemoveActive);
                 this.removeEventListener(
                     'pointerleave',
                     this.handleRemoveActive
                 );
+                this.removeEventListener(
+                    'pointercancel',
+                    this.handleRemoveActive
+                );
             }
         }
         if (this.anchorElement) {