-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request for Annotations feature for horizontal Bar Graphs #230
Comments
If you increase the height of your bar chart, do the annotations show up? We have something where if the width/height of the bar gets too small, the annotation won't show. Not saying it isn't a bug, just trying to troubleshoot a bit. |
Hey @marshallpete can you mention the specific height/width at which the annotations are hiden? I did explored the same by putting some values for the height/width prop in chart but could not get it to show the annotations for horizontal bar graph. |
@arushi474 Sorry for the delay, I created another bug with more details and how to fix. I’ll fix this one next week. |
Thanks again for the thorough details. You’ll see in the other issue that the root cause is that we never properly setup annotations for horizontal bars. If the width of the bar is less than 48px, we hide the annotation. This should be updated so that with a horizontal bar, if the height of the bar is less than the height of the text, we hide the annotation. |
Hey @marshallpete by when can I expect this to be fixed? |
I might have some time next week or it's open for contribution if you want to take a crack at it. |
Hi @marshallpete any update on this? |
@arushi474 I started some discovery on this one. I have some solution ideas. There are a few additional edge cases I'm trying to solve. Starting 6/3 I'm going to have a whole week to tackle stuff like this and this item is one of 3 at the top of my list. |
@marshallpete any update on this? |
Provide a general summary of the feature here
Annotations doesn't work for bar graph when orientation is horizontal.
🤔 Expected Behavior?
💁 Possible Solution
You can enable/build the annotaions to work for horizontal bar graph.
🔦 Context
As you can see it is enabled for verical bar graphs, But the same doesn't work for horizontal bar graphs.
As show below,
💻 Examples
This is the required behaviour
🧢 Your Company/Team
Adobe/Connect
The text was updated successfully, but these errors were encountered: