Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(win): fix 'require' problems on windows #260

Merged
merged 1 commit into from
Nov 17, 2020
Merged

fix(win): fix 'require' problems on windows #260

merged 1 commit into from
Nov 17, 2020

Conversation

tripodsan
Copy link
Contributor

fixes #259

@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@b6710ea). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #260   +/-   ##
=======================================
  Coverage        ?   84.37%           
=======================================
  Files           ?       90           
  Lines           ?     3955           
  Branches        ?        0           
=======================================
  Hits            ?     3337           
  Misses          ?      618           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6710ea...67d87cc. Read the comment docs.

@tripodsan tripodsan merged commit 177c892 into main Nov 17, 2020
@tripodsan tripodsan deleted the fix-windows-build branch November 17, 2020 07:22
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 17, 2020

This pull request introduces 1 alert when merging 67d87cc into b6710ea - view on LGTM.com

new alerts:

  • 1 for Incomplete string escaping or encoding

github-actions bot pushed a commit that referenced this pull request Nov 17, 2020
@semantic-release-bot
chore(release): 6.2.3 [skip ci]
8e04a8d 
## [6.2.3](v6.2.2...v6.2.3) (2020-11-17)

### Bug Fixes

* **win:** fix 'require' problems on windows ([#260](#260)) ([177c892](177c892)), closes [#259](#259)
@github-actions
Copy link

🎉 This PR is included in version 6.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build fails on windows
1 participant
@tripodsan