Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(htl): toplevel properties are case insensitive #255

Merged
merged 1 commit into from
Nov 1, 2020
Merged

fix(htl): toplevel properties are case insensitive #255

merged 1 commit into from
Nov 1, 2020

Conversation

tripodsan
Copy link
Contributor

fixes #254

@codecov
Copy link

codecov bot commented Nov 1, 2020 •
edited
Loading

Codecov Report

Merging #255 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
+ Coverage   84.34%   84.37%   +0.02%     
==========================================
  Files          90       90              
  Lines        3953     3954       +1     
==========================================
+ Hits         3334     3336       +2     
+ Misses        619      618       -1
Impacted Files Coverage Δ
src/compiler/Compiler.js 99.40% <100.00%> (ø)
src/compiler/ExpressionFormatter.js 82.78% <100.00%> (ø)
src/parser/commands/VariableBinding.js 100.00% <100.00%> (ø)
src/parser/plugins/IncludePlugin.js 91.89% <100.00%> (ø)
src/parser/plugins/ListPlugin.js 100.00% <100.00%> (ø)
src/parser/plugins/ResourcePlugin.js 100.00% <100.00%> (ø)
src/parser/plugins/UnwrapPlugin.js 100.00% <100.00%> (ø)
src/parser/plugins/UsePlugin.js 91.66% <100.00%> (ø)
src/runtime/Runtime.js 91.07% <0.00%> (+0.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc5718a...dd5c607. Read the comment docs.

@tripodsan tripodsan merged commit 09d31f1 into master Nov 1, 2020
@tripodsan tripodsan deleted the caseinsenstive-vars branch November 1, 2020 07:16
adobe-bot pushed a commit that referenced this pull request Nov 1, 2020
@semantic-release-bot
chore(release): 6.2.1 [skip ci]
12312e6 
## [6.2.1](v6.2.0...v6.2.1) (2020-11-01)

### Bug Fixes

* **htl:** toplevel properties are case insensitive ([#255](#255)) ([09d31f1](09d31f1)), closes [#254](#254)
@adobe-bot
Copy link

🎉 This PR is included in version 6.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

variable defined by data-sly-use cannot be found unless it is lowercase
2 participants
@tripodsan @adobe-bot