Refactor template handling #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tripodsan
force-pushed
the
use-in-template
branch
from
becb912 to
e949c3a
Compare
|
This PR will trigger a major release when merged. |
tripodsan
changed the title
Codecov Report
@@ Coverage Diff @@
## master #220 +/- ##
==========================================
+ Coverage 83.68% 83.74% +0.05%
==========================================
Files 86 87 +1
Lines 3818 3844 +26
==========================================
+ Hits 3195 3219 +24
- Misses 623 625 +2
Continue to review full report at Codecov.
|
tripodsan
force-pushed
the
use-in-template
branch
from
e949c3a to
cd46ad3
Compare
adobe-bot
pushed a commit
that referenced
this pull request
Jul 29, 2020
# [5.0.0](v4.6.2...v5.0.0) (2020-07-29) ### Bug Fixes * **compiler:** refactor template resolution ([#220](#220)) ([b64729b](b64729b)), closes [#216](#216) * **element:** data-sly-element should default to existing tag if not allowed ([#228](#228)) ([3f457ba](3f457ba)), closes [#223](#223) * **uri:** undefined uri ([#229](#229)) ([3dc23b7](3dc23b7)), closes [#221](#221) [#222](#222) ### BREAKING CHANGES * **compiler:** - The templateLoader and scriptResolver are now 2 separate functions that can be set on the compiler - The Runtime.template() has an extra argument 'id' that specifies the group (script) the template is defined.
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
templateLoaderandscriptResolverare now 2 separate functions that can be set on the compilerRuntime.template()has an extra argument 'id' that specifies the group (script) the template is defined.fixes #216 #208