Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler): add ability to specify template loader #173

Merged
merged 1 commit into from
May 7, 2020
Merged

feat(compiler): add ability to specify template loader #173

merged 1 commit into from
May 7, 2020

Conversation

tripodsan
Copy link
Contributor

fixes #172

@codecov
Copy link

codecov bot commented May 4, 2020 •
edited
Loading

Codecov Report

Merging #173 into master will increase coverage by 0.09%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
+ Coverage   83.60%   83.69%   +0.09%     
==========================================
  Files          85       86       +1     
  Lines        3793     3815      +22     
==========================================
+ Hits         3171     3193      +22     
  Misses        622      622
Impacted Files Coverage Δ
src/compiler/Compiler.js 99.32% <85.71%> (+0.68%) ⬆️
src/compiler/TemplateLoader.js 95.00% <95.00%> (ø)
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 655f5db...c5bdab7. Read the comment docs.

@github-actions
Copy link

github-actions bot commented May 4, 2020

This PR will trigger a minor release when merged.

@tripodsan tripodsan merged commit 076ad15 into master May 7, 2020
@tripodsan tripodsan deleted the template-loader branch May 7, 2020 01:30
adobe-bot pushed a commit that referenced this pull request May 7, 2020
@semantic-release-bot
chore(release): 4.4.0 [skip ci]
eb58da5 
# [4.4.0](v4.3.1...v4.4.0) (2020-05-07)

### Features

* **compiler:** add ability to specify template loader ([#173](#173)) ([076ad15](076ad15)), closes [#172](#172)
@adobe-bot
Copy link

🎉 This PR is included in version 4.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trieloff trieloff trieloff approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add possibility to specify multiple project roots for template loading
3 participants
@tripodsan @adobe-bot @trieloff