Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The URL gets trunctated when there is a comma in the document filename when the copy URL function is used #658

Closed
michaelktiufb opened this issue Jan 19, 2024 · 2 comments · Fixed by #660
Labels
bug Something isn't working released

Comments

@michaelktiufb
Copy link

Description
When you are in SharePoint and open Sidekick, there is a copy URL function that appears when a file is selected. It works fine EXCEPT when the document name contains a comma

To Reproduce
Steps to reproduce the behavior:
Upload any document in SharePoint with a filename that has a comma e.g "this,is a test.dox"
2. Open Sidekick, log in and select the document
3. In SharePoint select the file and click the "Copy URL" function (preview or live)
4. Check the copied URL

Expected behavior
Complete URL path is returned

Actual behavior
URL was truncated on the part where the comma is "e.g. https://somedomain.com/drafts/this
instead of https://somedomain.com/drafts/this-is-a-test

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Business impact: Users would have to manually construct the URL in preview or publish mode which is not easy for neophyte users

@michaelktiufb michaelktiufb added the bug Something isn't working label Jan 19, 2024
@flx-sta
Copy link

flx-sta commented Jan 23, 2024

The same problem occurs with a . in the filename

e.g: my-image.01.jpg

@rofe rofe closed this as completed in #660 Jan 24, 2024
@trieloff
Copy link
Contributor

🎉 This issue has been resolved in version 6.40.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants