This repository has been archived by the owner on Feb 28, 2022. It is now read-only.
feat(pipe): add timing information and clean up function name reporting #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 45 46 +1
Lines 999 1022 +23
=====================================
+ Hits 999 1022 +23
Continue to review full report at Codecov.
|
ramboz
approved these changes
May 24, 2019
| @@ -324,10 +324,10 @@ class Pipeline { | |||
| */ | |||
| const execTaps = async (taps, fnIdent, fnIdx) => { | |||
| for (const [idx, t] of iter(taps)) { | |||
| const ident = getident(t, 'tap', idx); | |||
| logger.silly(`exec ${ident} before ${fnIdent}`); | |||
| const ident = `#${String(fnIdx).padStart(2, '0')}/${fnIdent}/tap-#${idx}`; | |||
There was a problem hiding this comment.
You may take that opportunity to fix the type: ident => indent
There was a problem hiding this comment.
ident as in identifier is correct.
There was a problem hiding this comment.
Ah sorry, misread the code. I thought this was computing indentation 🤦♂
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #333