Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deploy): use latest helix-shared that enforces a defaut for 'ref'… #746

Merged
merged 1 commit into from
Apr 10, 2019

Conversation

tripodsan
Copy link
Contributor

… in string urls

fixes #741

@tripodsan tripodsan force-pushed the deploy-issue-with-demo branch from 0290e80 to 8a6efba Compare April 10, 2019 01:38
@codecov
Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #746 into master will decrease coverage by 0.49%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #746     +/-   ##
=========================================
- Coverage   88.55%   88.06%   -0.5%     
=========================================
  Files          43       42      -1     
  Lines        1896     2195    +299     
  Branches        0      325    +325     
=========================================
+ Hits         1679     1933    +254     
- Misses        217      262     +45
Impacted Files Coverage Δ
src/cli.js 78.43% <0%> (-16.92%) ⬇️
src/config/config-utils.js 80.95% <0%> (-19.05%) ⬇️
src/cli-util.js 76.92% <0%> (-3.08%) ⬇️
src/parcel/RawJSPackager.js 86.15% <0%> (-2.94%) ⬇️
src/git-utils.js 98.61% <0%> (-1.39%) ⬇️
src/openwhisk/static.js 98.86% <0%> (-1.14%) ⬇️
src/abstract.cmd.js 81.39% <0%> (-0.96%) ⬇️
src/build.cmd.js 94% <0%> (-0.88%) ⬇️
src/parcel/ExternalsCollector.js 87.03% <0%> (-0.47%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b50693...8a6efba. Read the comment docs.

@tripodsan tripodsan merged commit bef11ed into master Apr 10, 2019
@tripodsan tripodsan deleted the deploy-issue-with-demo branch April 10, 2019 01:43
trieloff pushed a commit that referenced this pull request Apr 10, 2019
## [0.14.1](v0.14.0...v0.14.1) (2019-04-10)

### Bug Fixes

* **deploy:** use latest helix-shared that enforces a defaut for 'ref' in string urls ([#746](#746)) ([bef11ed](bef11ed)), closes [#741](#741)
@tripodsan
Copy link
Contributor Author

🎉 This PR is included in version 0.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deploy falsely claims no strains affected by remote repo
1 participant