fix: do not forward the referer #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will trigger a patch release when merged. |
Codecov Report
@@ Coverage Diff @@
## main #2091 +/- ##
=======================================
Coverage 95.33% 95.34%
=======================================
Files 23 23
Lines 3324 3327 +3
Branches 1 1
=======================================
+ Hits 3169 3172 +3
Misses 155 155
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tripodsan
approved these changes
Nov 10, 2022
No clue what's best. Not sure if they typically write some logic on the edge to validate the referrers. |
adobe-bot
pushed a commit
that referenced
this pull request
Nov 10, 2022
## [14.17.1](v14.17.0...v14.17.1) (2022-11-10) ### Bug Fixes * do not forward the referrer ([#2091](#2091)) ([39eed86](39eed86))
|
🎉 This PR is included in version 14.17.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2090
The importer proxy forward the referer, which is always a localhost url. Just removing it unblocks the request from #2090. I even wonder why more of customer imported sites did not complain.
PR is also fixing the failing linting introduced by 645fdfa.