Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(embed): fix embed generated link #1359

Merged
merged 1 commit into from
Apr 10, 2020
Merged

fix(embed): fix embed generated link #1359

merged 1 commit into from
Apr 10, 2020

Conversation

kptdobe
Copy link
Contributor

@kptdobe kptdobe commented Apr 9, 2020

Corresponding fix for adobe/helix-pipeline#662

@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #1359 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1359   +/-   ##
=======================================
  Coverage   92.21%   92.21%           
=======================================
  Files          40       40           
  Lines        2005     2005           
=======================================
  Hits         1849     1849           
  Misses        156      156           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3187700...d5820fe. Read the comment docs.

@kptdobe
Copy link
Contributor Author

kptdobe commented Apr 9, 2020

The tests will fail until adobe/helix-pipeline#663 is merged.

@tripodsan tripodsan merged commit a2c39ff into master Apr 10, 2020
@tripodsan tripodsan deleted the fix-embeds branch April 10, 2020 00:42
trieloff pushed a commit that referenced this pull request Apr 10, 2020
## [8.1.12](v8.1.11...v8.1.12) (2020-04-10)

### Bug Fixes

* **embed:** fix embed generated link ([#1359](#1359)) ([a2c39ff](a2c39ff))
@adobe-bot
Copy link
Collaborator

🎉 This PR is included in version 8.1.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants