-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): create transparent builds #1198
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1198 +/- ##
==========================================
- Coverage 92.18% 91.92% -0.27%
==========================================
Files 44 38 -6
Lines 1855 1795 -60
==========================================
- Hits 1710 1650 -60
Misses 145 145
Continue to review full report at Codecov.
|
ba7afeb
to
494532a
Compare
LGTM. The |
yes please, i'd rather not copy the source files to the build folder again.... |
I assume all the existing tests validate that the build works as before. |
yes...some of the tests were modified and the JSX test is skipped. Also, since we don't use parcel anymore, building no longer validates the sources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be needed to keep JSX support?
Some sort of JSX processor... but I would (re)add it, once someone asks about it :-) |
494532a
to
b70d9c7
Compare
The JSX processing is done by Line 340 in b70d9c7
|
b70d9c7
to
9bc51db
Compare
I cleaned up the dependencies :-) but I'll see what can be done :-) |
8c6c722
to
7ddfb07
Compare
@trieloff I added JSX support again.... no more breaking change :-) |
fixes #1197 - removed parcel dependency - faster builds - transparently require source files
7ddfb07
to
980f982
Compare
🎉 This PR is included in version 5.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes #1197
a simple
html.htl
with ahtml.pre.js
is now transformed into:with a generated:
html.js
the
html.htl
was transformed intohtml.script.js
.in case of a pure script, like
xml.js
with a customxml.pipe.js
:with a generated:
xml.js