Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deploy): use major version for helix-static #1166

Merged
merged 1 commit into from
Oct 7, 2019
Merged

fix(deploy): use major version for helix-static #1166

merged 1 commit into from
Oct 7, 2019

Conversation

tripodsan
Copy link
Contributor

fixes #1165

@tripodsan tripodsan requested a review from trieloff October 5, 2019 12:15
@codecov
Copy link

codecov bot commented Oct 5, 2019 •
edited
Loading

Codecov Report

Merging #1166 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1166      +/-   ##
==========================================
+ Coverage   92.06%   92.08%   +0.01%     
==========================================
  Files          44       44              
  Lines        1841     1844       +3     
==========================================
+ Hits         1695     1698       +3     
  Misses        146      146
Impacted Files Coverage Δ
src/deploy.cmd.js 81.74% <100%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e460b75...d41eb00. Read the comment docs.

kptdobe
kptdobe approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@kptdobe kptdobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corresponding test could be added.

@tripodsan tripodsan merged commit 8598e36 into master Oct 7, 2019
@tripodsan tripodsan deleted the mix-helix-statix branch October 7, 2019 07:46
trieloff pushed a commit that referenced this pull request Oct 7, 2019
@semantic-release-bot
chore(release): 5.4.8 [skip ci]
0c4828d 
## [5.4.8](v5.4.7...v5.4.8) (2019-10-07)

### Bug Fixes

* **deploy:** use major version for helix-statix fixes [#1165](#1165) ([#1166](#1166)) ([8598e36](8598e36))
@adobe-bot
Copy link
Collaborator

🎉 This PR is included in version 5.4.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kptdobe kptdobe kptdobe approved these changes

@trieloff trieloff Awaiting requested review from trieloff

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hlx deploy should use major version for binding helix-statics
3 participants
@tripodsan @adobe-bot @kptdobe