feat(up): hlx up defaults to local repo

[stefan-guggisberg]

fix #913

Please ensure your pull request adheres to the following guidelines:

• make sure to link the related issues in this description
• when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

Thanks for contributing!

[codecov]

Codecov Report

Merging #1149 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1149   +/-   ##
=======================================
  Coverage   92.02%   92.02%           
=======================================
  Files          44       44           
  Lines        1830     1830           
=======================================
  Hits         1684     1684           
  Misses        146      146

Impacted Files	Coverage Δ
src/up.js	85% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 387ce6e...6afa114. Read the comment docs.

[tripodsan]

please add test for --no-local-repo

[tripodsan]

@stefan-guggisberg I added a commit that adds more tests and removes the --no-local-repo option. this is not required since yargs does this automatically for --no-* args.
feel free to change it again.

[stefan-guggisberg]

please add test for --no-local-repo

there already was a test for --no-local-repo:

helix-cli/test/testUpCli.js

Lines 212 to 218 in 387ce6e

	it('hlx up can specify no local repo', () => {
	new CLI()
	.withCommandExecutor('up', mockUp)
	.run(['up', '--no-local-repo']);
	sinon.assert.calledWith(mockUp.withLocalRepo, []);
	sinon.assert.calledOnce(mockUp.run);
	});

[stefan-guggisberg]

@stefan-guggisberg I added a commit that adds more tests and removes the --no-local-repo option. this is not required since yargs does this automatically for --no-* args.

@tripodsan I learned about the automagic support for --no-* args the hard way, i.e. I wasted too much time debugging yargs. It's not well documented :/

I explicitly added the --no-local-repo option in order to show up on hlx up --help.

[tripodsan]

I explicitly added the --no-local-repo option in order to show up on hlx up --help.

but then we should also add it to the help for hlx up --no-open, just to be consistent.

[stefan-guggisberg]

regarding the failing smoke test:
adobe/project-helix.io#62

[adobe-bot]

🎉 This PR is included in version 5.2.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀