Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action may not need to run npm install #124

Open
purplecabbage opened this issue Jan 26, 2021 · 0 comments
Open

Add action may not need to run npm install #124

purplecabbage opened this issue Jan 26, 2021 · 0 comments

Comments

@purplecabbage
Copy link
Member

When running aio app add action many times package.json is NOT modified, but we still run npm install which takes a around 10 seconds every time.

Expected Behaviour

package.json not modified, npm install NOT run

Actual Behaviour

package.json not modified, npm install IS run

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Platform and Version

Sample Code that illustrates the problem

aio app init
aio app add action // pick generic

Logs taken while reproducing problem

? We are about to create a new sample action that showcases how to access an external API.
How would you like to name this action? generic-6
identical package.json
   create actions/generic-6/index.js
   create test/actions/generic-6.test.js
identical actions/utils.js
identical test/actions/utils.test.js
   create e2e/actions/generic-6.e2e.js


I'm all done. Running npm install for you to install the required dependencies. If this fails, try running the command yourself.
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants