Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

fix for issue 8111 exclude .sass-cache folder in project view #8458

Merged
merged 2 commits into from
Jul 18, 2014
Merged

fix for issue 8111 exclude .sass-cache folder in project view #8458

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18575c8
fix for issue 8111 exclude .sass-cache folder in project view
mackenza Jul 18, 2014
60cdeba
change order of new entry based on review
mackenza Jul 18, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/project/ProjectManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ define(function (require, exports, module) {
* https://github.com/adobe/brackets/issues/6781
* @type {RegExp}
*/
var _exclusionListRegEx = /\.pyc$|^\.git$|^\.gitmodules$|^\.svn$|^\.DS_Store$|^Thumbs\.db$|^\.hg$|^CVS$|^\.hgtags$|^\.idea$|^\.c9revisions$|^\.SyncArchive$|^\.SyncID$|^\.SyncIgnore$|\~$/;
var _exclusionListRegEx = /\.pyc$|^\.git$|^\.gitmodules$|^\.svn$|^\.DS_Store$|^Thumbs\.db$|^\.hg$|^CVS$|^\.hgtags$|^\.idea$|^\.c9revisions$|^\.SyncArchive$|^\.SyncID$|^\.sass-cache$|^\.SyncIgnore$|\~$/;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: how about moving the new item before ^\.SyncArchive$ so it does not break those already in alphabetic order?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I don't care about alphabetizing this, but SyncArchive/SyncID/SyncIgnore are sort of a related set so it feels weird to stick this new entry in the middle of them. We should either add it at the end, or before them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totally agree... I honestly didn't see any order... I will change it in a few minutes.


/**
* @private
Expand Down