Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

fix for issue 8111 exclude .sass-cache folder in project view #8458

Merged
merged 2 commits into from
Jul 18, 2014
Merged

fix for issue 8111 exclude .sass-cache folder in project view #8458

merged 2 commits into from
Jul 18, 2014

Conversation

mackenza
Copy link
Contributor

adds the .sass-cache folder to the list of files and folders excluded from view in the project tree.

addresses issue #8111

@@ -106,7 +106,7 @@ define(function (require, exports, module) {
* https://github.com/adobe/brackets/issues/6781
* @type {RegExp}
*/
var _exclusionListRegEx = /\.pyc$|^\.git$|^\.gitmodules$|^\.svn$|^\.DS_Store$|^Thumbs\.db$|^\.hg$|^CVS$|^\.hgtags$|^\.idea$|^\.c9revisions$|^\.SyncArchive$|^\.SyncID$|^\.SyncIgnore$|\~$/;
var _exclusionListRegEx = /\.pyc$|^\.git$|^\.gitmodules$|^\.svn$|^\.DS_Store$|^Thumbs\.db$|^\.hg$|^CVS$|^\.hgtags$|^\.idea$|^\.c9revisions$|^\.SyncArchive$|^\.SyncID$|^\.sass-cache$|^\.SyncIgnore$|\~$/;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: how about moving the new item before ^\.SyncArchive$ so it does not break those already in alphabetic order?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I don't care about alphabetizing this, but SyncArchive/SyncID/SyncIgnore are sort of a related set so it feels weird to stick this new entry in the middle of them. We should either add it at the end, or before them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totally agree... I honestly didn't see any order... I will change it in a few minutes.

@peterflynn
Copy link
Member

Looks good -- thanks!

peterflynn added a commit that referenced this pull request Jul 18, 2014
fix for issue 8111 exclude .sass-cache folder in project view
@peterflynn peterflynn merged commit d1b5c13 into adobe:master Jul 18, 2014
@peterflynn peterflynn mentioned this pull request Aug 5, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants