This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
[Themes] Removed waiting until to app is ready to apply themes in order to get ri... #8419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rid of the flicker when the editor loads each time it is opened #8377
|
@TomMalbran I included your jsdoc suggestions in this pull request. Thanks it really helped |
| * @param {File} file for the theme | ||
| * @param {string} displayName is an optional parameter used as the display name for the theme | ||
| */ | ||
| * @constructor |
There was a problem hiding this comment.
Do you want to add a simple description here? It will look better in the Docs page
There was a problem hiding this comment.
|
@MiguelCastillo Great. I think they look good now. |
|
@TomMalbran Man, I must have an actual lexical limitation! Keep getting those nits in there. Thanks for catching them. |
|
@MiguelCastillo Jeje, it is still hard to see them. You have to do a close review to find them |
|
cc @dangoor |
|
Ok, not all three in ThemeManager, but all three checkins touch ThemeManager and ThemeSettings |
|
This does indeed fix the style flash. Thanks! |
dangoor
added a commit
that referenced
this pull request
Jul 16, 2014
[Themes] Removed waiting until to app is ready to apply themes in order to get ri...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...d of the flicker when the editor loads each time it is opened
#8377