Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Added Traditional Chinese translation. #8332

Merged
merged 50 commits into from
Jul 15, 2014
Merged

Conversation

tan9
Copy link
Contributor

@tan9 tan9 commented Jul 7, 2014

Added zh-tw translation, any suggestion will be appreciated.

@tan9
Copy link
Contributor Author

tan9 commented Jul 8, 2014

I can not sign the CLI unless the name of my country was corrected #8337

@peterflynn
Copy link
Member

@tan9 The CLA page has been updated (you may need to refresh or clear cache to see it)

@tan9
Copy link
Contributor Author

tan9 commented Jul 8, 2014

@peterflynn , thank you!
I signed the CLA.

@tan9 tan9 changed the title [WIP] Added Traditional Chinese translation. Added Traditional Chinese translation. Jul 11, 2014
@tan9
Copy link
Contributor Author

tan9 commented Jul 11, 2014

@peterflynn , I have finished it.
Can somebody here help reviewing this PR?

@peterflynn
Copy link
Member

Marking 'triage complete' so we can find a reviewer. @tan9 can you suggest anyone else on GitHub who speaks Traditional Chinese, who could review this?

Also, one piece of feedback: because of the way our Windows installers are built, the "Getting Started" folder name has to be made of up basic English characters only. So you will need to rename that folder to use an English transliteration, unfortunately.

@tan9
Copy link
Contributor Author

tan9 commented Jul 12, 2014

@jenghung, @lyhcode, could you please help reviewing this PR?

@@ -57,5 +57,6 @@ define({
"LOCALE_SR" : "Српски",
"LOCALE_SV" : "svenska",
"LOCALE_TR" : "Türkçe",
"LOCALE_ZH_CN" : "简体中文"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is duplicated with next row, and lack of ","

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means this change appended a "," to end of line, and GitHub doesn't display inline changes well.

  • - with red background means deletion of line,
  • + with green background means addition of line.

@lyhcode
Copy link

lyhcode commented Jul 13, 2014

Nice job. I've tried this translation. All things are done well. Thanks to @tan9.

@larz0
Copy link
Member

larz0 commented Jul 13, 2014

@peterflynn I can take this one if needed.

@peterflynn
Copy link
Member

@larz0 Feel free to give it a skim -- that would be awesome! Doesn't have to be too painstaking since it looks like two others gave it a look too.

tan9 added 2 commits July 14, 2014 09:45
Like what we did in strings.js.
Microsoft JhengHei Bold must have a value greater or equal to 700 to match.
@tan9
Copy link
Contributor Author

tan9 commented Jul 14, 2014

@yiming , @lyhcode , thank you for your support.

@larz0 , @peterflynn , thank you for taking look at this PR, hope it can reach the same quality as the rest of Brackets 👍

@larz0
Copy link
Member

larz0 commented Jul 14, 2014

Looks good here 👍

@tan9
Copy link
Contributor Author

tan9 commented Jul 15, 2014

@larz0 , Thanks for your reviewing.
@peterflynn , I have updated the translation to date, would this PR be merged in this sprint?

@peterflynn
Copy link
Member

@tan9 Since the reviewers have said it's good and the last few updates look ok too, I think we can merge it now.

peterflynn added a commit that referenced this pull request Jul 15, 2014
Added Traditional Chinese translation.
@peterflynn peterflynn merged commit 2d8fac2 into adobe:master Jul 15, 2014
@redmunds redmunds mentioned this pull request Jul 15, 2014
@tan9 tan9 deleted the nls-zh-tw branch July 16, 2014 01:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants