Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Adding Code Hints Description Box for handling additional hint information in LSP #14696

Merged
merged 7 commits into from
Apr 14, 2019

Conversation

shubhsnov
Copy link
Collaborator

@shubhsnov shubhsnov commented Apr 11, 2019

LSP allows a server to serve additional information about a completionItem(hint) upon explicit request.
This additional information can be quite large, and doesn't sit nicely with the current UI where all the extra information is shown inline as the element is highlighted.

Current UI:

image

New UI:

image
newUi

ping @swmitra @narayani28 for review

This feature will be enabled on request through "enableDescription" option in the hints response. The provider can then subsequently create any html and render in the description box through the updateHintDescription interface in the provider.

See this and this for reference.

Copy link
Collaborator

@swmitra swmitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@swmitra swmitra merged commit 4e55d2a into master Apr 14, 2019
@narayani28
Copy link
Collaborator

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants