This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
jsRefactor Rename Relative Path issue fixed #14520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niteskum
changed the title
niteskum
changed the title
boopeshmahendran
suggested changes
Aug 27, 2018
| @@ -98,7 +99,17 @@ define(function (require, exports, module) { | |||
|
|
|||
| function isInSameFile(obj, refsResp) { | |||
| // In case of unsaved files, After renameing once Tern is returning filename without forward slash | |||
| return (obj && (obj.file === refsResp.file || obj.file === refsResp.file.slice(1, refsResp.file.length))); | |||
| var projectDir = ProjectManager.getProjectRoot().fullPath, | |||
There was a problem hiding this comment.
Check if ProjectManager.getProjectRoot() returns null
|
|
||
| // get the relative path of File as Tern can also return | ||
| // references with file name as a relative path wrt projectRoot | ||
| // so refernce file will be compared with both relative and Absolute path ti check if it is same file |
boopeshmahendran
approved these changes
Aug 27, 2018
nyteksf
pushed a commit
to nyteksf/brackets
that referenced
this pull request
Sep 8, 2018
author Nitesh Kumar <[email protected]> 1535377091 +0530 committer nyteksf <[email protected]> 1536424652 -0700 jsRefactor Rename Relative Path issue fixed (adobe#14520) * jsRefactor Rename Realtice Path issue fixed * Addressed review comments Delete .gitignore Exclude .gitignore, config.json Repair error, Refactor error handling for localStorage Add package.json to merge repos
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename doesn't work if TernNodeDomain return Refs with path relative to project Root.
So added check it will compare both Absolute path and Relative path so if either of these is true Refs will be considered in same file.
@boopeshmahendran @navch please review