Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

CSSInlineEditor: rule list is not hidden when deleting a rule if there are only two #5575

Closed
marcelgerber opened this issue Oct 18, 2013 · 3 comments · Fixed by #5646
Closed

CSSInlineEditor: rule list is not hidden when deleting a rule if there are only two #5575

marcelgerber opened this issue Oct 18, 2013 · 3 comments · Fixed by #5646
Assignees
@njx
Labels
low priority

Comments

@marcelgerber
Copy link
Contributor

  1. Navigate to Getting Started/index.html.
  2. Open an Inline Editor for <body>.
  3. Add a New Rule. Type anything in and save.
  4. While in the InlineEditor (in the new rule), hit Ctrl+A and press backspace (backspacing all works, too).

Result:
The rule was deleted (I think it is intended to do so), but the rule list on the right is still shown (normally, it isn't shown when there is only one rule).
Also, the save indicator is there on the rule even if everything was saved (it doesn't hide).

image

Windows 8
@ghost ghost assigned njx Oct 18, 2013
@njx
Copy link

njx commented Oct 18, 2013

I think this is the way it has always worked, so not a regression. It would seem consistent to hide the rule list in this case. Marking low priority to me.

@marcelgerber marcelgerber mentioned this issue Oct 22, 2013
Merged
@njx
Copy link

njx commented Oct 22, 2013

There's another way you can hit this: by going to the CSS file and deleting one of the underlying rules that's matched in an open inline editor. It's not very common though.

@marcelgerber
Copy link
Contributor Author

@njx Thanks for mentioning this, I just filed a related bug (#5643).

@marcelgerber marcelgerber reopened this Oct 23, 2013
@marcelgerber marcelgerber mentioned this issue Oct 23, 2013
Merged
@njx njx closed this as completed in #5646 Nov 1, 2013
njx pushed a commit that referenced this issue Nov 1, 2013
Merge pull request #5646 from SAPlayer/fix-5575
cb7beed 
Fix #5575: Rule list hides as soon as there is only one rule left
@core-ai-bot core-ai-bot mentioned this issue Aug 30, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@njx njx

Labels
low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #5575: Rule list hides as soon as there is only one rule left marcelgerber/brackets
2 participants
@njx @marcelgerber