UI jiggles when opening context menu on selection

[peterflynn]

1. Select a few lines of text in any file
2. Right-click on the selection

Result: entire UI jiggles upward about 1 line's height, then back down

This definitely worked correctly when we originally introduced context menus.

Looks like this might be due to CMv3: it's broken as far back as Sprint 20, but working correctly in Sprint 19 and earlier. Sprint 20 is when v3 landed.

[njx]

Not seeing this on Mac--might be Windows only.

[redmunds]

Bizarre. I only see it on Win7 if 8 or more lines are selected.

[njx]

I was wrong--it does appear on Mac if you select multiple lines and context-click on the selection.

[RaymondLim]

More bizarre thing. If your selection covers more than 75% of the window height, then you don't see the issue.

[dattadev]

It's happening when we selected a single line wrapped into 2-3 lines and then context click on the selection. I am using "sprint 22 experimental build 0.22.0-6428"

[TomMalbran]

Another bizarre thing. If hold the right click for a few seconds before releasing it, then it doesn't jiggle.

[RaymondLim]

Hmm.. Somehow this issue is not reproducible in the latest version 6f2dabd (both win and mac)

[RaymondLim]

Identify that nj's commit 8c655d2 also fixes this issue.

FBNC @peterflynn

[TomMalbran]

I can still reproduce this on WinXP at the latest version 6f2dabd33. But I can now only see the editor holder moving rapidly one line up and down by selecting between 4 and 17 lines and opening the context menu clicking inside the selection.

[njx]

Our conjecture is that it was (accidentally) fixed by the changes/simplifications made for the new toolbar layout (which were merged last night). I'll see if I can reproduce it on XP.

[njx]

Oops, I meant "I'll see if I can reproduce it on Win 7" :) I wasn't able to repro it on Win 7, so if this is XP-only I think this can be pushed out of this sprint as a low-priority bug.

[jokeyrhyme]

Sprint 27, OS X 10.8:

1. open Brackets
2. select file
3. select multiple lines
4. right-click
5. observe weirdness where code editor meets file list

There is no jitter now, just the weirdness with the arrow point on the active file highlighting.

[peterflynn]

I can still repro that last issue -- the sidebar panel jumps upward and the arrow gets misaligned -- on Win 7 when right clicking a selection that's several lines long. It seems to happen more easily when right-clicking in the top half of the window, but I'm not sure. Doesn't seem to depend on window height (large or small, I can hit it either way).

[redmunds]

I fixed another cause of this in pull request #6665. In that case, the window was being stretched vertically which messed up the project tree, so maybe something similar is happening here.

[redmunds]

FBNC to @peterflynn

[marcelgerber]

Well, it's not completely fixed. The Editor actually jiggles a bit, but without any persistent effect.

[JeffryBooher]

Strange. I don't see it at all on Windows 8.

[njx]

I can still repro on Mac with the latest master.

[redmunds]

Yes, I still see the jiggle. Removing FBNC.

[redmunds]

The UI Jiggling still remains, but the worst part of this bug (i.e. sidebar gap) is now fixed, so removing Brackets 1.0 Milestone.