Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Line number in inline editor header doesn't update for edits from other inline editor #2919

Closed
peterflynn opened this issue Feb 20, 2013 · 5 comments
Closed

Line number in inline editor header doesn't update for edits from other inline editor #2919

peterflynn opened this issue Feb 20, 2013 · 5 comments
Assignees
@njx
Milestone
sprint 22

Comments

@peterflynn
Copy link
Member

  1. Open the Getting Started project
  2. Open one inline editor on <html> and one on <body>
  3. Add some newlines in the <html> inline editor

Result: in the <body> inline editor, the line number in the header is unchanged. The numbers increases as epxected in the gutter and the results list, however.

There's code in InlineTextEditor._updateLineRange() that's supposed to update this header (and it definitely used to work) -- so something has broken there.
@peterflynn
Copy link
Member Author

This was originally spotted by @njx while doing CodeMirror doc-view split research. I'll add a note there.

@ghost ghost assigned njx Feb 25, 2013
@njx
Copy link

njx commented Feb 25, 2013

Reviewed. To me, medium priority, not for this sprint.

@pthiess
Copy link
Contributor

pthiess commented Feb 25, 2013

Reviewed @njx

@njx
Copy link

njx commented Mar 8, 2013

Nominating for sprint 22.

@njx njx mentioned this issue Mar 13, 2013
Merged
@jasonsanjose
Copy link
Member

Confirmed fixed. Closing.

@core-ai-bot core-ai-bot mentioned this issue Aug 29, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@njx njx

Labels
None yet
Projects
None yet
Milestone
sprint 22
Development

No branches or pull requests
4 participants
@njx @jasonsanjose @peterflynn @pthiess