Right Click on Inactive Files Glitch in OSX

[georgestephanis]

I'm running the Sprint 16 build under OSX 10.8.2 on a Retina MBP 15".

When I right-click on an inactive file, three things happen:

1. It displays the context menu,
2. It opens the file for editing,
3. It hides the context menu again, as the file just opened.

And all three of these occur before I release the right mouse button.

The brief flicker of a context menu is a bit confusing. UX wise, I'd prefer right clicking not open the file (that's what left clicking is for) but display the context menu instead -- but that's just my 2¢.

Talked to redmunds in IRC, and the issue does not seem to be duplicating on the Windows 7 version. For him, right clicking on an inactive file just opens it -- no context menu is displayed, however briefly.

[redmunds]

To clear up a miscommunication on IRC, I am getting a context menu, but not until right mouse button is released.

[peterflynn]

This may be a dupe of #1910 -- I think the only difference is the suggestion here that right-clicking shouldn't change the selection.

[georgestephanis]

Yup, same issue. Why do we have right-click as opening the file, anyways? It strikes me as counter-intuitive, but I'm happy to be proven wrong.

[pthiess]

Reviewed, assigned to @peterflynn - low prio.

[peterflynn]

Closing since this is a dupe.

Re why it changes selection: it's fairly common to do that to avoid ambiguity about what the context menu commands will apply to. Sublime does the same thing, for example. We could be fancier and instead of changing selection use a second item highlighting style that to indicate the target of the right click (e.g. see Outlook... or Espresso), but that'd be an enhancement.