Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Custom font is ignored #13221

Closed
3 tasks done
thany opened this issue Mar 24, 2017 · 13 comments
Closed
3 tasks done

Custom font is ignored #13221

thany opened this issue Mar 24, 2017 · 13 comments
Milestone

Comments

@thany
Copy link

thany commented Mar 24, 2017

Prerequisites

  • Can you reproduce the problem with Debug -> Reload Without Extensions?
  • Did you perform a cursory search to see if your bug or enhancement is already reported?
  • Did you read the Troubleshooting guide?

Description

A custom font set in View->Themes is ignored.

Steps to Reproduce

  1. Open Brackets
  2. View->Themes
  3. Set any other font. In my case, Fira Code, so: Fira Code, FiraCode, 'SourceCodePro-Medium', MS ゴシック, 'MS Gothic', monospace

Expected behavior:
Custom font should be displayed in the editor.

Actual behavior:
Custom font is set, but only once, after committing the setting. After zooming in/out, after a restart, or a reload, the default font is displayed again.

Versions

Brackets 1.9
Windows 10

This is a regression from 1.8, where setting a custom font worked just fine.

@zmyjs
Copy link

zmyjs commented Mar 24, 2017

‘I’ve been through the same situation!

@prasadmudedla
Copy link

same situation... tried changing the defaultPreferneces.json.... Still no luck...

@clementi
Copy link

clementi commented Mar 24, 2017

I'm seeing this also. Windows 7 and Windows 10.

@guillecro
Copy link

This issue is already posted here,
#13205

Its not working even in Ubuntu (in my case Ubuntu 16.04 LTS x64)

@thany
Copy link
Author

thany commented Mar 27, 2017

That appears to be a different issue, as it also reports the problem in 1.8.
This particular case is a regression from 1.8, meaning the feature worked fine in 1.8, but it broke as of 1.9.

@0xnigel
Copy link

0xnigel commented Mar 31, 2017

I have modified the brackets.min.css.

@thany
Copy link
Author

thany commented Mar 31, 2017

Can this please be fixed with a maintenance update?

It happens too often that we need to wait 3 months or longer, for an issue to get solved in the next release. And any new release may introduce other breaking bugs, causing us to have to wait even longer.

@guillecro
Copy link

Can this please be fixed with a maintenance update?

I +1 this comment. Its such annoying bug..

@jpdupont
Copy link

+1

@swmitra
Copy link
Collaborator

swmitra commented Apr 1, 2017

@thany We are working on this issue and hopefully have a fix by next week. Once the fix is in, we will trigger a pre-release which would be available under Brackets GitHub releases.

@vahid-sanati
Copy link

vahid-sanati commented Apr 2, 2017

I have this bug too.
When I change the font in preferences, the font changes. But after restarting brackets it shows with default font.

@swmitra
Copy link
Collaborator

swmitra commented Apr 10, 2017

Closing this as fixed by #13279 and available as part of 1.10 pre-release 1 build https://github.com/adobe/brackets/releases/tag/release-1.10-prerelease-1

@swmitra swmitra closed this as completed Apr 10, 2017
@thany
Copy link
Author

thany commented May 23, 2017

I just noticed 1.9 is still up as the latest release, even though this bug is still in there, supposedly. Why aren't you releasing this 1.10-prerelease as a maintenance update to 1.9? You can call it 1.9.1 or something.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants