Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiya 👋 and Ty 🙏 #154

Open
PaulieScanlon opened this issue Nov 24, 2020 · 8 comments
Open

Hiya 👋 and Ty 🙏 #154

PaulieScanlon opened this issue Nov 24, 2020 · 8 comments

Comments

@PaulieScanlon
Copy link

📝 Feedback

Hi, I'm Paul. I'm the chap that made MDX Embed. I spotted this morning that you're using it... I'm really excited by this and if there's anything i can help with please do let me know!

🔦 Context

Discovering Adobe are using my Open-source work has absolutely made my day! Thanks team!!!

@bdenham
Copy link
Contributor

bdenham commented Jun 4, 2021

Hey @PaulieScanlon! We're using Gatsby 3.6.0 and we're getting a warning not being compatible with the latest versions of Gatsby ^3.0.0.

Any chance you can update your plugin to be compatible?

@PaulieScanlon
Copy link
Author

Hey @bdenham yes I’ve had a few folk mention this. The warning shouldn’t be a massive problem and I’m still assessing if updating the peer deps to v3 will work for our users. If we do users on Gatsby v2 will then see a warning. I think we’re nearly there in regards to “time to upgrade” but perhaps in another month or so. Perhaps I could release an alpha version for v3 users in the meantime. Would that help you out?

@bdenham
Copy link
Contributor

bdenham commented Jun 8, 2021

Sure! We can help test an alpha version. Thanks for letting us know!

@PaulieScanlon
Copy link
Author

Hey @bdenham Just to let you know i've started looking into preparing a Gatsby v3 -alpha turns out it's a little more tricky than i first thought. Leave it with me and i'll see if i can get get it sorted soon!

@bdenham
Copy link
Contributor

bdenham commented Jun 9, 2021

Awesome, thanks! I'd be interested to know what makes it tricky, not out of doubt, but out of personal curiosity. If I find some time in the near future, I'd be interested in learning more about the specific challenges that plugin developers are encountering when moving to v3.x from 2.x. Please contact me directly via [email protected] and via Slack later when you start getting into the conversion work. Thanks for the update!

@PaulieScanlon
Copy link
Author

Hey @bdenham problem solved. The Gatsby part was pretty easy. I had some Cirlce CI and Cypress issues and a weird problem with one of the examples which was a red herring -- anyway i've just released an alpha version for you to try out.

Please do let me know how you get on. Oh and, it has a peer dep of Gatsby 3.2.0

gatsby-plugin-mdx-embed: 0.0.20-alpha

@bdenham
Copy link
Contributor

bdenham commented Jun 10, 2021

Excellent! Thank you! I'll try it out soon. Really appreciate your quick response and update. Talk more soon.

@PaulieScanlon
Copy link
Author

Hey team, how's it going? Did you get change to test the alpha? I think it's good to go but a cheeky double check from folks out there using it always helps! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants