Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rollup-plugin-cleanup module #36

Open
kptdobe opened this issue Jan 23, 2024 · 0 comments
Open

Replace rollup-plugin-cleanup module #36

kptdobe opened this issue Jan 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@kptdobe
Copy link
Contributor

kptdobe commented Jan 23, 2024

To shape a proper aem.js (formatting, comments cleanup...), we use rollup-plugin-cleanup plugin for rollup, but this module has not been touched for 4 years now and starts creating dependencies issues (depends on old rollup-pluginutils).
We should find another solution.

The plugin is used for: (see config https://github.com/adobe/aem-lib/blob/main/rollup.config.js#L49-L52)

  • make sure aem.js passes the aem-boilerplate linting rules (including: keep eslint instructions, remove // comments, line breaks, indentation)
  • do not duplicate license comments (only one license at the beginning of the concatenated file)
  • get rid of c8 comments
@kptdobe kptdobe added the enhancement New feature or request label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant