Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minify aem.js ? #21

Open
kptdobe opened this issue Oct 2, 2023 · 0 comments
Open

Minify aem.js ? #21

kptdobe opened this issue Oct 2, 2023 · 0 comments
Labels
question Further information is requested

Comments

@kptdobe
Copy link
Contributor

kptdobe commented Oct 2, 2023

Not completely convinced this is a good idea but... We should not write aem.js from https://github.com/adobe/aem-boilerplate/ since this is a generated file from this repo. How do we avoid people making PR against that file in the boilerplate, apart from writing it in the doc... Minifying the file would solve that problem (they would need to find the source) but on the other hand, this will block people from easily look at the file.
For sure, #20 is a must-have prior doing this one.
@kptdobe kptdobe added the question Further information is requested label Oct 2, 2023
@kptdobe kptdobe changed the title Minify aem.js Minify aem.js ? Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kptdobe