-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Support for recent Angular Versions #65
Comments
This really needs to get updated to be compatible with latest versions of Angular |
Is anyone using this with Angular 13? We tried to upgrade to 13, but as mentioned above received 'incompatible peer dependencies' warnings. After deploying to our AEM instance, we just get a blank page. No errors that we could find in the logs. |
It has also become a critical issue for us. We are stuck with unsupported Angular version due to incompatibility. Is there any chance that Adobe will support and update it so that at least 13 (LTS version, with security updates, but preferably 14 or 15 as 13 LTS will end in May) is supported? |
Hi, v2.0.0 |
Hello, If you could please remove those changes or propose different solution. |
I refactored the packages, available here: https://www.npmjs.com/package/@kav-khalsa/aem-angular-editable-components and https://www.npmjs.com/package/@kav-khalsa/adobe-aem-spa-model-manager, using standalone, on Angular 18. The issue is that the packages instantiate the services/models in the packages which slows it down and is not compatible with Angular version 16 and above. So I have refactored everything and used Angular services so it operates a whole lot faster. @Eldrisch , please take a look and let me know how you get on. |
Hello, We have tested what Eldrish indicated and I confirm that, by replacing that portion of code, the library works correctly. Thanks a lot |
Is your feature request related to a problem? Please describe.
Currently the aem-angular-editable-components library is supporting and using Angular Version 9, so we are currently already 4 versions behind to current version 13. Also the package does not run/support Ivy by default, which is the standard nowadays.
So we would like the be able to update to at least version 12 and be able to run with Ivy enabled without any issues, and no npm dependency version warning.
Describe the solution you'd like
Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered: