Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardcoded architecture #17

Closed
holomorph opened this issue Nov 4, 2014 · 8 comments
Closed

hardcoded architecture #17

holomorph opened this issue Nov 4, 2014 · 8 comments

Comments

@holomorph
Copy link
Contributor

The flag -m32 is littered throughout the build configuration.

~/bin/afdko/FDK/Tools/Programs]$ find -type f -exec grep m32 {} +
./public/lib/config/linux/gcc/gcc.mak: XFLAGS = -m32
./public/lib/config/linux/gcc/gcc_tx.mak: XFLAGS = -m32
./spot/build/linux/gcc/debug/Makefile:CFLAGS = $(STD_OPTS) -m32 -g -I$(ROOT_DIR)/sfnt_includes -I$(SRC_DIR) -DEXECUTABLE=1 -g
./spot/build/linux/gcc/release/Makefile:CFLAGS = $(STD_OPTS) -m32 -g -I$(ROOT_DIR)/sfnt_includes -I$(SRC_DIR) -DEXECUTABLE=1
./sfntedit/build/linux/gcc/debug/Makefile:CFLAGS = $(STD_OPTS) -m32  -g -I$(ROOT_DIR)/../spot/sfnt_includes
./sfntedit/build/linux/gcc/release/Makefile:CFLAGS = $(STD_OPTS) -m32 -I$(ROOT_DIR)/../spot/sfnt_includes
./sfntdiff/build/linux/gcc/debug/Makefile:CFLAGS = $(STD_OPTS) -m32 -g -I$(ROOT_DIR)/../spot/sfnt_includes
./sfntdiff/build/linux/gcc/release/Makefile:CFLAGS = $(STD_OPTS) -m32 -I$(ROOT_DIR)/../spot/sfnt_includes

Is there any reason for this? If you're fine with removing it, I'd be happy to make a pull request.

@nlsp
Copy link

nlsp commented Nov 4, 2014

Also, the whole linux build environment seems to assume gcc is the standard compiler.

Both Xcode and FreeBSD are on their way to phase out gcc in favor of LLVM/clang. It would be very nice if ‘linux/gcc’ could be made more BSD friendly.

@holomorph
Copy link
Contributor Author

Should probably be a separate issue. At the very least, one can do CC=clang ./BuildAllLinux.sh.

@readroberts
Copy link
Contributor

Feel free to fix this. I know almost nothing about the Linux environment; I learned just enough to make a Linux build for the roughly 4 users who have asked for it. I do want the build system to continue to make 32 bit builds only. This is because type developers typically don't have money to upgrade machines very often, and 2 of four Linux flavor FDK users (that I know about) are still running 32 bit intel systems.

@behdad
Copy link
Contributor

behdad commented Nov 19, 2014

I think you are hugely underestimating the number of Linux users of this suite of tools :).

@kenlunde
Copy link

I agree with @behdad. Although a small number of people specifically requested it, I am sure that the number of people using AFDKO on Linux is much larger. A quick search of social media activity suggests this.

@chemoelectric
Copy link

32-bit dependence is a bug; it should not be happening. And not everyone even has a multilib environment capable of building and running 32-bit programs. I would think fixing this ought to be a priority even without known users.

@davelab6
Copy link

2 of four Linux flavor FDK users (that I know about

Is the FDK instrumented to report daily users? :)

@readroberts
Copy link
Contributor

Thank you. I see that I can still build 32 bit executables for my FDK distribution simply by building on a 32 bit Linux system.
The FDK download page is not instrumented; my information about who uses the FDK comes only from who posts questions and issues about the FDK on the several forums.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants