Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Umbrella header cannot be found using cocoa pods #728

Closed
egarni opened this issue Aug 29, 2024 · 8 comments
Closed

Umbrella header cannot be found using cocoa pods #728

egarni opened this issue Aug 29, 2024 · 8 comments

Comments

@egarni
Copy link

egarni commented Aug 29, 2024

Hello, I'm trying to update to version 5 using CocoaPods, and I'm getting this error:

Pods/Adjust/ModuleMap/module.modulemap:2:19: error: umbrella header 'AdjustSdk.h' not found
  umbrella header "AdjustSdk.h"
                  ^
<unknown>:0: error: could not build Objective-C module 'AdjustSdk'

Anything you are aware of?

@Aditi3
Copy link
Member

Aditi3 commented Aug 29, 2024

Hi @egarni ,

Could you try running pod update command for your application and let us know if that helps?

@egarni
Copy link
Author

egarni commented Sep 4, 2024

Still the same
Screenshot 2024-09-04 at 08 32 58

@genadyb
Copy link
Contributor

genadyb commented Sep 9, 2024

Hello, @egarni.
In order to fully understand the issue, we would like to ask you to provide us with more details about your integration.

  • Where are you integrating Adjust SDK, application / other SDK / etc.?
  • What platform are you targeting?
  • What is the language of your consumer App / SDK / etc.?
  • What version of Adjust SDK had you used before you tried to update to a V5?
  • Please share here the Podfile you are using to integrate Adjust SDK.
  • How did you perform the update process? What steps have you gone through?

We will try to understand the issue and help you as fast as possible.
Thank you.

@egarni
Copy link
Author

egarni commented Sep 10, 2024

  • Trying to integrate the SDK in an iOS app,
  • Targeting iOS 15.0
  • We use Swift in the entire app
  • We used Adjust 4.38.4 without any issues

Here a simplified podfile showing how we integrate:

source 'https://cdn.cocoapods.org/'
platform :ios, '13.0'
inhibit_all_warnings!
use_frameworks!

workspace 'kry'

target "kry" do
    pod 'Firebase/Crashlytics'
    pod 'Adjust'

    target "kry-tests" do
        inherit! :search_paths
    end
end

target "CoreLibrary" do
    pod 'Adjust'
end

post_install do |installer|
    installer.pods_project.targets.each do |target|
        target.build_configurations.each do |config|
            config.build_settings['SWIFT_VERSION'] = '5.9'
            config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '15.0'
        end
        # Xcode 14 beta fix: https://github.com/CocoaPods/CocoaPods/issues/8891#issuecomment-1201465446
        if target.respond_to?(:product_type) and target.product_type == "com.apple.product-type.bundle"
          target.build_configurations.each do |config|
              config.build_settings['CODE_SIGNING_ALLOWED'] = 'NO'
          end
        end
    end
end

The main app kry, has a dependency to another library CoreLibrary, and adjust is linked in both

  • To update, I ran pod update, and followed the migration guide to fix the breaking api changes, and then got the error from this issue

@genadyb
Copy link
Contributor

genadyb commented Sep 12, 2024

@egarni
Thank you for the information.
We will re-check it shortly and let you know.

@genadyb
Copy link
Contributor

genadyb commented Sep 13, 2024

Hello, @egarni.
We've tried to reproduce your issue, but unfortunately without success.
The Swift App integrating 4.38.4 is successfully updated to Adjust V5 after the pod update.
Is there any chance that some of your Podfile configuration is missing after you simplified it?
Thank you.

@egarni
Copy link
Author

egarni commented Sep 17, 2024

I can see that a fix has been made here
I updated to version 5.0.1, and I can now compile. So everything is good now, thank for looking into the issue 👍

@uerceg
Copy link
Contributor

uerceg commented Sep 17, 2024

Hey @egarni,

Thank you very much for the feedback. We did encounter similar (but it seems related to yours) issue, but we were unsure if yours is also affected by that or not. Good to know that 5.0.1 solves your problem as well.

Thank you one more time for reporting and for all the feedback in here.

Cheers.

@uerceg uerceg closed this as completed Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants