Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.38.0 Missing nullability type specifier #703

Closed
JanikReese opened this issue Mar 25, 2024 · 5 comments
Closed

4.38.0 Missing nullability type specifier #703

JanikReese opened this issue Mar 25, 2024 · 5 comments

Comments

@JanikReese
Copy link

iOS: 17.2
Adjust SDK: Upgraded from 4.37.0 to 4.38.0
Xcode: 15.2

We are seeing warning about missing nullability type specifier in ADJUrlStrategy.h and ADJUtil.h.
Those warnings convert into build errors within the testing target and the module won't build.

image image
@Aditi3
Copy link
Member

Aditi3 commented Apr 8, 2024 •
edited
Loading

Hi @JanikReese

I tried to reproduce this for our example application but could not do so on my end as an error.

Can you check if the Treat Warnings as Errors option is set to Yes under Build Settings for your application? Setting it to No may help.

@JanikReese
Copy link
Author

Hey @Aditi3 and thanks for your answer.

This is also reproducible within a freshly created demo project.
Regardless if this warning is treated as an error or not we aim for 0 warnings in our project and a fix would be much appreciated.

image

@Aditi3
Copy link
Member

Aditi3 commented Apr 9, 2024

We have added this to our roadmap and will work on eliminating warnings from our SDK soon.

Thanks again for bringing this to our attention @JanikReese

@uerceg uerceg mentioned this issue Apr 10, 2024
Merged
@Aditi3
Copy link
Member

Aditi3 commented Apr 10, 2024

Hi @JanikReese,

Our latest release addresses the issue. We would appreciate it if you could give v4.38.1 a shot and let us know if it works.

Thank you in advance!

@JanikReese
Copy link
Author

JanikReese commented Apr 10, 2024 •
edited
Loading

Hi @Aditi3, it seems to be working fine now.
Thanks for your super quick support.

This was referenced Apr 30, 2024
Merged
Merged
Merged
github-merge-queue bot referenced this issue in valora-inc/wallet May 30, 2024
@renovate @satish-ravi
fix(deps): update dependency react-native-adjust to ^4.38.1 (#5470)
60b0d54 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [react-native-adjust](https://togithub.com/adjust/react_native_sdk) |
[`^4.38.0` ->
`^4.38.1`](https://renovatebot.com/diffs/npm/react-native-adjust/4.38.0/4.38.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-adjust/4.38.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-adjust/4.38.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-adjust/4.38.0/4.38.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-adjust/4.38.0/4.38.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>adjust/react_native_sdk (react-native-adjust)</summary>

###
[`v4.38.1`](https://togithub.com/adjust/react_native_sdk/blob/HEAD/CHANGELOG.md#Version-4381-30th-April-2024)

[Compare
Source](https://togithub.com/adjust/react_native_sdk/compare/v4.38.0...v4.38.1)

##### Added

- Added sending of the additional iOS SDK observability parameters for
debugging purposes.

##### Fixed

- Removed nullability type specifier warnings
([https://github.com/adjust/ios_sdk/issues/703](https://togithub.com/adjust/ios_sdk/issues/703)).

##### Native SDKs

-   \[[email protected]]\[ios_sdk_v4.38.2]
-   \[[email protected]]\[android_sdk_v4.38.3]

***

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbIm5wbSIsInJlbm92YXRlIl19-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Satish Ravi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Aditi3 @JanikReese