Using different bins for different detectors throws errors

[adivijaykumar]

If one uses different bins for different detectors, one gets errors. The current code sets common bins for all detectors, even though it calculates stuff for all detectors. This is not a problem if the minimum frequency and the maximum frequency are the same across detectors, but would be a problem otherwise.

We were getting this error:

Traceback (most recent call last):
  File "bilby_likelihood_error.py", line 134, in <module>
    print("Relative Binning Likelihood:", likelihood_relbin.log_likelihood())
  File "/home/aditya.vijaykumar/work/relbin/bilby/bilby/gw/likelihood.py", line 1534, in log_likelihood
    return self.log_likelihood_ratio() + self.noise_log_likelihood()
  File "/home/aditya.vijaykumar/work/relbin/bilby/bilby/gw/likelihood.py", line 1544, in log_likelihood_ratio
    interferometer)
  File "/home/aditya.vijaykumar/work/relbin/bilby/bilby/gw/likelihood.py", line 1657, in compute_relative_ratio
    new_polarizations = self.waveform_generator.frequency_domain_strain(parameter_dictionary)
  File "/home/aditya.vijaykumar/work/relbin/bilby/bilby/gw/waveform_generator.py", line 129, in frequency_domain_strain
    transformed_model_data_points=self.time_array)
  File "/home/aditya.vijaykumar/work/relbin/bilby/bilby/gw/waveform_generator.py", line 165, in _calculate_strain
    if self.parameters == self._cache['parameters'] and self._cache['model'] == model and \
ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
(relbin) [aditya.vijaykumar@dodo ~]$ vim /home/aditya.vijaykumar/work/relbin/bilby/bilby/gw/waveform_generator.py