This repository has been archived by the owner on May 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabauke
reviewed
Apr 3, 2023
Would be nice if you could add a test for those two warnings:
|
derrabauke
reviewed
Apr 3, 2023
derrabauke
approved these changes
Apr 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! 🎉
adfinisbot
pushed a commit
that referenced
this pull request
Apr 5, 2023
## [3.1.2](v3.1.1...v3.1.2) (2023-04-05) ### Bug Fixes * **activities:** dont delete records while in flight ([#898](#898)) ([b9c9316](b9c9316)) * **analysis:** enlarge accountants bulk editing capabilities ([#895](#895)) ([f844c9d](f844c9d)) * attendance validation ([a4b1812](a4b1812)) * change the error message, and the tests ([6ca6185](6ca6185)) * fix of tests after changing the return type ([979e411](979e411)) * hbs warnings ([#894](#894)) ([b00f97b](b00f97b)) * negative activities possible ([f6392ad](f6392ad)) * **sy-checkbox:** add scss for indeterminate state ([7c27966](7c27966)) * **task-selection:** make selection more robust ([91edd83](91edd83))
🎉 This PR is included in version 3.1.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
StephanH90
pushed a commit
to StephanH90/timed-frontend
that referenced
this pull request
Aug 8, 2023
* fix: hbs warnings * fix: (user-controller): action naming and invocation * fix: writing tests for new change * fix: code readability
StephanH90
pushed a commit
to StephanH90/timed-frontend
that referenced
this pull request
Aug 8, 2023
## [3.1.2](adfinis/timed-frontend@v3.1.1...v3.1.2) (2023-04-05) ### Bug Fixes * **activities:** dont delete records while in flight ([adfinis#898](adfinis#898)) ([b9c9316](adfinis@b9c9316)) * **analysis:** enlarge accountants bulk editing capabilities ([adfinis#895](adfinis#895)) ([f844c9d](adfinis@f844c9d)) * attendance validation ([a4b1812](adfinis@a4b1812)) * change the error message, and the tests ([6ca6185](adfinis@6ca6185)) * fix of tests after changing the return type ([979e411](adfinis@979e411)) * hbs warnings ([adfinis#894](adfinis#894)) ([b00f97b](adfinis@b00f97b)) * negative activities possible ([f6392ad](adfinis@f6392ad)) * **sy-checkbox:** add scss for indeterminate state ([7c27966](adfinis@7c27966)) * **task-selection:** make selection more robust ([91edd83](adfinis@91edd83))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.