Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

fix: hbs warnings #894

Merged
merged 4 commits into from
Apr 3, 2023
Merged

fix: hbs warnings #894

merged 4 commits into from
Apr 3, 2023

Conversation

MitanOmar
Copy link
Member

No description provided.

app/users/edit/responsibilities/controller.js Outdated Show resolved Hide resolved
app/users/index/controller.js Outdated Show resolved Hide resolved
@derrabauke
Copy link
Contributor

Would be nice if you could add a test for those two warnings:

app/users/edit/responsibilities/controller.js#L19
Added line #L19 was not covered by tests
app/users/index/controller.js#L39
Added line #L39 was not covered by tests

Copy link
Contributor

@derrabauke derrabauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 🎉

@derrabauke derrabauke merged commit b00f97b into master Apr 3, 2023
@derrabauke derrabauke deleted the fix-lint-warning-2 branch April 3, 2023 16:13
adfinisbot pushed a commit that referenced this pull request Apr 5, 2023
## [3.1.2](v3.1.1...v3.1.2) (2023-04-05)

### Bug Fixes

* **activities:** dont delete records while in flight ([#898](#898)) ([b9c9316](b9c9316))
* **analysis:** enlarge accountants bulk editing capabilities ([#895](#895)) ([f844c9d](f844c9d))
* attendance validation ([a4b1812](a4b1812))
* change the error message, and the tests ([6ca6185](6ca6185))
* fix of tests after changing the return type ([979e411](979e411))
* hbs warnings ([#894](#894)) ([b00f97b](b00f97b))
* negative activities possible ([f6392ad](f6392ad))
* **sy-checkbox:** add scss for indeterminate state ([7c27966](7c27966))
* **task-selection:** make selection more robust ([91edd83](91edd83))
@adfinisbot
Copy link
Member

🎉 This PR is included in version 3.1.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

StephanH90 pushed a commit to StephanH90/timed-frontend that referenced this pull request Aug 8, 2023
* fix: hbs warnings

* fix: (user-controller): action naming and invocation

* fix: writing tests for new change

* fix: code readability
StephanH90 pushed a commit to StephanH90/timed-frontend that referenced this pull request Aug 8, 2023
## [3.1.2](adfinis/timed-frontend@v3.1.1...v3.1.2) (2023-04-05)

### Bug Fixes

* **activities:** dont delete records while in flight ([adfinis#898](adfinis#898)) ([b9c9316](adfinis@b9c9316))
* **analysis:** enlarge accountants bulk editing capabilities ([adfinis#895](adfinis#895)) ([f844c9d](adfinis@f844c9d))
* attendance validation ([a4b1812](adfinis@a4b1812))
* change the error message, and the tests ([6ca6185](adfinis@6ca6185))
* fix of tests after changing the return type ([979e411](adfinis@979e411))
* hbs warnings ([adfinis#894](adfinis#894)) ([b00f97b](adfinis@b00f97b))
* negative activities possible ([f6392ad](adfinis@f6392ad))
* **sy-checkbox:** add scss for indeterminate state ([7c27966](adfinis@7c27966))
* **task-selection:** make selection more robust ([91edd83](adfinis@91edd83))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants