This repository was archived by the owner on May 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 20
feat: add magic link component to create a magic link that can be sent to another user #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db301f1
to
8de7442
Compare
I'm not gonna write tests for the error messages because I don't see the point. You are welcome to write them if you think they make sense. |
derrabauke
suggested changes
Jul 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! ✨ If you add the suggested ignore-comments coverage will be just as shiny. 👍
…t to another user
8de7442
to
2df655f
Compare
derrabauke
approved these changes
Jul 24, 2023
adfinisbot
pushed a commit
that referenced
this pull request
Jul 28, 2023
# [3.2.0](v3.1.5...v3.2.0) (2023-07-28) ### Bug Fixes * **activities:** prevent doubling time while generating reports ([#970](#970)) ([96f1a37](96f1a37)) * changing project in the activity bar when change the recent customer ([#998](#998)) ([05a3ce5](05a3ce5)) * **customer-visible-icon:** splatter attributes ([ee5a2b8](ee5a2b8)) * **statistics-list:** allotted efforts calculation ([a0643b4](a0643b4)) * **tests:** parameter compatibility of reports abilities ([3fc5648](3fc5648)) * the bar is green only if the task is archived and have no remeaning ([369f942](369f942)) ### Features * add magic link component to create a magic link that can be sent to another user ([#1022](#1022)) ([4096c58](4096c58)) * improve statistics bar chart rendering ([b1f1d98](b1f1d98)) * writing tests for chart rendering ([699906e](699906e))
🎉 This PR is included in version 3.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closing #681 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have wanted this feature for a long time. Behold! It's done.
New magic link btn:
magic link popup:
when following the link:
The report can then be changed as desired or saved directly. When you reload the page, it doesn't create the same report again.