-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add list of available locations #125
Comments
See the PR for a proposal of a simple locations endpoint. |
We discussed today:
A note from me - the description for the location entity still references a Weight, so should be corrected. |
Consider authorization as well: this resource most likely only returns the list of identifiers that the client has access to. As we do not cover auth/autz yet, it may still be worth documenting. Also consider the growth path: other, more advanced, use cases are:
As far as I can see, it seems that this url scheme does not necessarily block that but we should consider that, e.g.: In #109 there is also a request for other "meta data" such as available scheme's and available identifiers for a scheme. We should probably consider these here as well. E.g.:
|
Sorry I had a day off yesterday, but now I pushed the discussed improvements to the PR:
|
@alamers I think we have to keep your points in mind, but I'd say there are no necessary changes for this resource for now. |
Just one thing that came to my mind right now: To improve discoverability and ease of use of the API, maybe we can add a This could look like |
Closing this now, but @MetroMarv if you would like to add the baseUrl field in ADE 1.1, please go ahead and re-open. |
In our case we need to retrieve a list of available locations (and their scheme) through the ICAR interface. In addition to scheme and id a description or name would be helpful.
This supports discoverability of supported schema/id combinations.
If necessary the list of schema/id combinations can be filtered by applying the user's privileges.
The text was updated successfully, but these errors were encountered: