From 109ede997461154902fec4892cd86f2bb89dc616 Mon Sep 17 00:00:00 2001
From: EdwinBetanc0urt <EdwinBetanc0urt@outlook.com>
Date: Mon, 6 Sep 2021 02:53:52 -0400
Subject: [PATCH 1/2] feat: Add window support ReadOnly field.

---
 .../Field/FieldOptions/preference/index.vue   | 17 ++---
 src/components/ADempiere/Field/index.vue      | 71 ++++++++++++++++---
 src/store/modules/ADempiere/fieldValue.js     | 28 +++++++-
 src/store/modules/ADempiere/preference.js     | 21 +++++-
 src/store/modules/user.js                     |  7 +-
 .../ADempiere/constants/systemColumns.js      | 25 +++++++
 src/views/ADempiere/Window/index.vue          | 34 +++++++++
 7 files changed, 176 insertions(+), 27 deletions(-)
 create mode 100644 src/utils/ADempiere/constants/systemColumns.js

diff --git a/src/components/ADempiere/Field/FieldOptions/preference/index.vue b/src/components/ADempiere/Field/FieldOptions/preference/index.vue
index d4351f560f8..4655307746f 100644
--- a/src/components/ADempiere/Field/FieldOptions/preference/index.vue
+++ b/src/components/ADempiere/Field/FieldOptions/preference/index.vue
@@ -106,6 +106,7 @@
 import formMixin from '@/components/ADempiere/Form/formMixin'
 import preferenceFields from './preferenceFields.js'
 import { createFieldFromDictionary } from '@/utils/ADempiere/lookupFactory'
+import { CLIENT, ORGANIZATION } from '@/utils/ADempiere/constants/systemColumns'
 import { setPreference, deletePreference } from '@/api/ADempiere/field/preference.js'
 import { showMessage } from '@/utils/ADempiere/notification.js'
 import language from '@/lang'
@@ -149,13 +150,13 @@ export default {
       if (this.isEmptyValue(this.metadataList)) {
         return ''
       }
-      const forCurrentUser = this.metadataList.find(field => field.columnName === 'AD_User_ID')
-      const forCurrentClient = this.metadataList.find(field => field.columnName === 'AD_Client_ID')
-      const forCurrentOrganization = this.metadataList.find(field => field.columnName === 'AD_Org_ID')
-      const forCurrentContainer = this.metadataList.find(field => field.columnName === 'AD_Window_ID')
+      const forCurrentClient = this.metadataList.find(field => field.columnName === CLIENT)
       if (!forCurrentClient) {
         return ''
       }
+      const forCurrentUser = this.metadataList.find(field => field.columnName === 'AD_User_ID')
+      const forCurrentOrganization = this.metadataList.find(field => field.columnName === ORGANIZATION)
+      const forCurrentContainer = this.metadataList.find(field => field.columnName === 'AD_Window_ID')
       //  Create Message
       var expl = language.t('components.preference.for')//  components.preference.for
       if (forCurrentOrganization && forCurrentClient) {
@@ -224,8 +225,8 @@ export default {
     },
     remove() {
       const isForCurrentUser = this.metadataList.find(field => field.columnName === 'AD_User_ID').value
-      const isForCurrentClient = this.metadataList.find(field => field.columnName === 'AD_Client_ID').value
-      const isForCurrentOrganization = this.metadataList.find(field => field.columnName === 'AD_Org_ID').value
+      const isForCurrentClient = this.metadataList.find(field => field.columnName === CLIENT).value
+      const isForCurrentOrganization = this.metadataList.find(field => field.columnName === ORGANIZATION).value
       const isForCurrentContainer = this.metadataList.find(field => field.columnName === 'AD_Window_ID').value
       deletePreference({
         parentUuid: this.fieldAttributes.parentUuid,
@@ -275,8 +276,8 @@ export default {
     },
     sendValue(list) {
       const isForCurrentUser = this.metadataList.find(field => field.columnName === 'AD_User_ID').value
-      const isForCurrentClient = this.metadataList.find(field => field.columnName === 'AD_Client_ID').value
-      const isForCurrentOrganization = this.metadataList.find(field => field.columnName === 'AD_Org_ID').value
+      const isForCurrentClient = this.metadataList.find(field => field.columnName === CLIENT).value
+      const isForCurrentOrganization = this.metadataList.find(field => field.columnName === ORGANIZATION).value
       const isForCurrentContainer = this.metadataList.find(field => field.columnName === 'AD_Window_ID').value
       //
       setPreference({
diff --git a/src/components/ADempiere/Field/index.vue b/src/components/ADempiere/Field/index.vue
index ffcfdab7178..6bb5b388177 100644
--- a/src/components/ADempiere/Field/index.vue
+++ b/src/components/ADempiere/Field/index.vue
@@ -66,6 +66,9 @@
 
 <script>
 import { evalutateTypeField, fieldIsDisplayed } from '@/utils/ADempiere/dictionaryUtils'
+import {
+  ACTIVE, CLIENT, PROCESSING, PROCESSED
+} from '@/utils/ADempiere/constants/systemColumns'
 import FieldOptions from '@/components/ADempiere/Field/FieldOptions'
 
 /**
@@ -240,11 +243,49 @@ export default {
     isPanelWindow() {
       return this.field.panelType === 'window'
     },
+
+    recordUuid() {
+      // is active record
+      return this.$store.getters.getValueOfField({
+        parentUuid: this.parentUuid,
+        containerUuid: this.containerUuid,
+        columnName: 'UUID'
+      })
+    },
+    containerIsActive() {
+      // panel processing value
+      return this.$store.getters.getValueOfField({
+        parentUuid: this.parentUuid,
+        containerUuid: this.containerUuid,
+        columnName: ACTIVE
+      })
+    },
+    containerIsProcessing() {
+      // panel processing value
+      return this.$store.getters.getValueOfField({
+        parentUuid: this.parentUuid,
+        containerUuid: this.containerUuid,
+        columnName: PROCESSING
+      })
+    },
+    containerIsProcessed() {
+      // panel processed value
+      return this.$store.getters.getValueOfField({
+        parentUuid: this.parentUuid,
+        containerUuid: this.containerUuid,
+        columnName: PROCESSED
+      })
+    },
+    containerClientId() {
+      // panel client value
+      return this.$store.getters.getValueOfField({
+        parentUuid: this.parentUuid,
+        containerUuid: this.containerUuid,
+        columnName: CLIENT
+      })
+    },
     preferenceClientId() {
-      if (this.isPanelWindow) {
-        return this.$store.getters.getPreferenceClientId
-      }
-      return undefined
+      return this.$store.getters.getPreferenceClientId
     },
 
     /**
@@ -259,14 +300,23 @@ export default {
         return false
       }
 
-      if (!this.field.isActive) {
-        return true
-      }
-
       // validate with container manager
       if (!this.isEmptyValue(this.containerManager) &&
         this.containerManager.validateReadOnly) {
-        return this.containerManager.validateReadOnly(this.field)
+        // TODO: Add validate method to record uuid uuid without route.action
+        // edit mode is diferent to create new
+        const isWithRecord = this.recordUuid !== 'create-new' &&
+          !this.isEmptyValue(this.recordUuid)
+        return this.containerManager.validateReadOnly({
+          field: this.field,
+          preferenceClientId: this.preferenceClientId,
+          // record values
+          clientId: this.containerClientId,
+          isActive: this.containerIsActive,
+          isProcessing: this.containerIsProcessing,
+          isProcessed: this.containerIsProcessed,
+          isWithRecord
+        })
       }
 
       const isUpdateableAllFields = this.field.isReadOnly || this.field.isReadOnlyFromLogic
@@ -275,9 +325,8 @@ export default {
         // TODO: Evaluate record uuid without route.action
         // edit mode is diferent to create new
         let isWithRecord = this.field.recordUuid !== 'create-new'
-        // TODO: Remove false condition to production
         // evaluate context
-        if ((this.preferenceClientId !== this.metadataField.clientId && 1 === 2) && isWithRecord) {
+        if ((this.preferenceClientId !== this.metadataField.clientId) && isWithRecord) {
           return true
         }
 
diff --git a/src/store/modules/ADempiere/fieldValue.js b/src/store/modules/ADempiere/fieldValue.js
index 3f8157e1c5c..27d674a2f7b 100644
--- a/src/store/modules/ADempiere/fieldValue.js
+++ b/src/store/modules/ADempiere/fieldValue.js
@@ -1,6 +1,25 @@
+// ADempiere-Vue (Frontend) for ADempiere ERP & CRM Smart Business Solution
+// Copyright (C) 2017-Present E.R.P. Consultores y Asociados, C.A.
+// Contributor(s): Edwin Betancourt EdwinBetanc0urt@outlook.com www.erpya.com
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with this program.  If not, see <https://www.gnu.org/licenses/>.
+
 import Vue from 'vue'
 import { isEmptyValue } from '@/utils/ADempiere/valueUtils.js'
 import { convertStringToBoolean } from '@/utils/ADempiere/valueFormat.js'
+import {
+  ACTIVE, PROCESSING, PROCESSED
+} from '@/utils/ADempiere/constants/systemColumns'
 
 const UUID_KEY = 'UUID'
 
@@ -8,6 +27,7 @@ const value = {
   state: {
     field: {}
   },
+
   mutations: {
     resetStatevalue(state) {
       state = {
@@ -84,6 +104,7 @@ const value = {
       })
     }
   },
+
   actions: {
     updateValuesOfContainer({ commit }, {
       parentUuid,
@@ -99,6 +120,7 @@ const value = {
       })
     }
   },
+
   getters: {
     getValueOfField: (state) => ({
       parentUuid,
@@ -173,17 +195,17 @@ const value = {
     },
     // Using to read only in data tables in Window
     getContainerIsActive: (state) => (parentUuid) => {
-      const valueIsActive = state.field[`${parentUuid}_IsActive`]
+      const valueIsActive = state.field[`${parentUuid}_${ACTIVE}`]
 
       return convertStringToBoolean(valueIsActive)
     },
     getContainerProcessing: (state) => (parentUuid) => {
-      const valueProcessing = state.field[`${parentUuid}_Processing`]
+      const valueProcessing = state.field[`${parentUuid}_${PROCESSING}`]
 
       return convertStringToBoolean(valueProcessing)
     },
     getContainerProcessed: (state) => (parentUuid) => {
-      const valueProcessed = state.field[`${parentUuid}_Processed`]
+      const valueProcessed = state.field[`${parentUuid}_${PROCESSED}`]
 
       return convertStringToBoolean(valueProcessed)
     }
diff --git a/src/store/modules/ADempiere/preference.js b/src/store/modules/ADempiere/preference.js
index 1df6c5c1f3c..b5a1f251f17 100644
--- a/src/store/modules/ADempiere/preference.js
+++ b/src/store/modules/ADempiere/preference.js
@@ -1,6 +1,23 @@
+// ADempiere-Vue (Frontend) for ADempiere ERP & CRM Smart Business Solution
+// Copyright (C) 2017-Present E.R.P. Consultores y Asociados, C.A.
+// Contributor(s): Edwin Betancourt EdwinBetanc0urt@outlook.com www.erpya.com
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with this program.  If not, see <https://www.gnu.org/licenses/>.
+
 import Vue from 'vue'
 // Delete when get global context and account context
 import { isEmptyValue, typeValue } from '@/utils/ADempiere/valueUtils.js'
+import { CLIENT, ORGANIZATION } from '@/utils/ADempiere/constants/systemColumns.js'
 
 const preference = {
   state: {
@@ -170,10 +187,10 @@ const preference = {
       return state.preference
     },
     getPreferenceClientId: (state) => {
-      return parseInt(state.preference['#AD_Client_ID'], 10)
+      return parseInt(state.preference['#' + CLIENT], 10)
     },
     getPreferenceOrgId: (state) => {
-      return parseInt(state.preference['#AD_Org_ID'], 10)
+      return parseInt(state.preference['#' + ORGANIZATION], 10)
     }
   }
 }
diff --git a/src/store/modules/user.js b/src/store/modules/user.js
index 4e9f35e5e98..3717bb6d9eb 100644
--- a/src/store/modules/user.js
+++ b/src/store/modules/user.js
@@ -29,6 +29,7 @@ import {
 import { resetRouter } from '@/router'
 import { showMessage } from '@/utils/ADempiere/notification'
 import { isEmptyValue } from '@/utils/ADempiere/valueUtils'
+import { ORGANIZATION } from '@/utils/ADempiere/constants/systemColumns'
 import language from '@/lang'
 
 const state = {
@@ -173,7 +174,7 @@ const actions = {
           commit('SET_ROLE', role)
           setCurrentRole(role.uuid)
           const currentOrganizationSession = sessionInfo.defaultContext.find(context => {
-            if (context.key === '#AD_Org_ID') {
+            if (context.key === '#' + ORGANIZATION) {
               return context
             }
           })
@@ -367,7 +368,7 @@ const actions = {
         }
         commit('SET_ORGANIZATION', organization)
         commit('setPreferenceContext', {
-          columnName: '#AD_Org_ID',
+          columnName: '#' + ORGANIZATION,
           value: organization.id
         }, {
           root: true
@@ -409,7 +410,7 @@ const actions = {
         commit('SET_ORGANIZATION', organization)
 
         // commit('setPreferenceContext', {
-        //   columnName: '#AD_Org_ID',
+        //   columnName: '#' + ORGANIZATION,
         //   value: organizationId
         // }, {
         //   root: true
diff --git a/src/utils/ADempiere/constants/systemColumns.js b/src/utils/ADempiere/constants/systemColumns.js
new file mode 100644
index 00000000000..25f512bcd33
--- /dev/null
+++ b/src/utils/ADempiere/constants/systemColumns.js
@@ -0,0 +1,25 @@
+// ADempiere-Vue (Frontend) for ADempiere ERP & CRM Smart Business Solution
+// Copyright (C) 2017-Present E.R.P. Consultores y Asociados, C.A.
+// Contributor(s): Edwin Betancourt EdwinBetanc0urt@outlook.com www.erpya.com
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with this program.  If not, see <https://www.gnu.org/licenses/>.
+
+export const CLIENT = 'AD_Client_ID'
+
+export const ORGANIZATION = 'AD_Org_ID'
+
+export const ACTIVE = 'IsActive'
+
+export const PROCESSING = 'Processing'
+
+export const PROCESSED = 'Processed'
diff --git a/src/views/ADempiere/Window/index.vue b/src/views/ADempiere/Window/index.vue
index 91b8b204d6c..a30421cc82d 100644
--- a/src/views/ADempiere/Window/index.vue
+++ b/src/views/ADempiere/Window/index.vue
@@ -111,6 +111,40 @@ export default defineComponent({
         }
 
         return isDisplayed && isDisplayedFromLogic
+      },
+
+      validateReadOnly({
+        field,
+        // preferenceClientId,
+        // clientId,
+        isActive,
+        isProcessing,
+        isProcessed,
+        isWithRecord
+      }) {
+        // TODO: Fix client and org with server
+        // evaluate context
+        // if (preferenceClientId !== clientId && isWithRecord) {
+        //   return true
+        // }
+        // record is inactive
+        if (!isActive && field.columnName !== 'IsActive') {
+          return true
+        }
+        if (field.isAlwaysUpdateable) {
+          return false
+        }
+        if (isWithRecord && (isProcessing || isProcessed)) {
+          return true
+        }
+
+        // not updateable and record saved
+        if (!field.isUpdateable && isWithRecord) {
+          return true
+        }
+        return (
+          field.isReadOnly || field.isReadOnlyFromLogic || field.isReadOnlyFromForm
+        )
       }
     }
 

From f5ed86ecac799410ec7a4edb185671210ebb2237 Mon Sep 17 00:00:00 2001
From: EdwinBetanc0urt <EdwinBetanc0urt@outlook.com>
Date: Mon, 6 Sep 2021 03:01:44 -0400
Subject: [PATCH 2/2] enable client validation.

---
 src/views/ADempiere/Window/index.vue | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/views/ADempiere/Window/index.vue b/src/views/ADempiere/Window/index.vue
index a30421cc82d..c4927802d12 100644
--- a/src/views/ADempiere/Window/index.vue
+++ b/src/views/ADempiere/Window/index.vue
@@ -115,18 +115,18 @@ export default defineComponent({
 
       validateReadOnly({
         field,
-        // preferenceClientId,
-        // clientId,
+        // records values
+        preferenceClientId,
+        clientId,
         isActive,
         isProcessing,
         isProcessed,
         isWithRecord
       }) {
-        // TODO: Fix client and org with server
         // evaluate context
-        // if (preferenceClientId !== clientId && isWithRecord) {
-        //   return true
-        // }
+        if (preferenceClientId !== clientId && isWithRecord) {
+          return true
+        }
         // record is inactive
         if (!isActive && field.columnName !== 'IsActive') {
           return true