Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Damaged inline SVG in HTML. #182

Closed
denistrator opened this issue Dec 8, 2016 · 3 comments
Closed

Damaged inline SVG in HTML. #182

denistrator opened this issue Dec 8, 2016 · 3 comments

Comments

@denistrator
Copy link

denistrator commented Dec 8, 2016

Hi.
I have problem. After compiling my .html file I have corrupt tags inside svg tag.
Comparing files - diffnow.com/?report=kz5sw before/left after/right.
Here are my settings:

       critical.generate({
            inline: true,
            base: './builds',
            src: 'index.html',
            dest: 'index.html',
            minify: true
        });

Thanks!

@bezoerb
Copy link
Collaborator

bezoerb commented Dec 12, 2016

@denistrator Thanks for reporting the issue. This seems to be an error with cheerio (Used for parsing the html document)

@bezoerb
Copy link
Collaborator

bezoerb commented Dec 12, 2016

See: fb55/htmlparser2#129

topaxi added a commit to topaxi/ember-app-shell that referenced this issue Sep 29, 2017
@bezoerb
Copy link
Collaborator

bezoerb commented Nov 29, 2018

Just identified & fixed (hopefully) another issue with inlined svgs.
Closing this issue due to inactivity. You can follow the progress in #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants