Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added DateRangePicker #91

Merged
merged 8 commits into from
Oct 14, 2020
Merged

feat: added DateRangePicker #91

merged 8 commits into from
Oct 14, 2020

Conversation

anuraghazra
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Oct 13, 2020 •
edited
Loading

Deploy preview for renderless-components ready!

Built with commit 0728a77

https://deploy-preview-91--renderless-components.netlify.app

@navin-moorthy
Copy link
Collaborator

Looks good, but it's better we merge it after #88

Alse seems isDisabled & isReadOnly stories, doesn't work as expected.

@anuraghazra
Copy link
Contributor Author

Looks good, but it's better we merge it after #88

Alse seems isDisabled & isReadOnly stories, doesn't work as expected.

Yeah first 88 then this one

navin-moorthy
navin-moorthy approved these changes Oct 14, 2020
View reviewed changes
Copy link
Collaborator

@navin-moorthy navin-moorthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@navin-moorthy navin-moorthy added component ⚙️ Issues or PR about a specific component API feature 🚀 Issue or PR that adds a feature or improvement labels Oct 14, 2020
@navin-moorthy navin-moorthy mentioned this pull request Oct 14, 2020
Merged
@anuraghazra anuraghazra merged commit 0a1cabd into master Oct 14, 2020
@navin-moorthy navin-moorthy deleted the date-range-picker branch October 14, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navin-moorthy navin-moorthy navin-moorthy approved these changes

Assignees

@anuraghazra anuraghazra

Labels
component ⚙️ Issues or PR about a specific component API feature 🚀 Issue or PR that adds a feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anuraghazra @navin-moorthy