Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(range-calendar): ♻️ review changes and fix bugs with space #61

Merged
merged 3 commits into from
Sep 30, 2020
Merged

refactor(range-calendar): ♻️ review changes and fix bugs with space #61

merged 3 commits into from
Sep 30, 2020

Conversation

navin-moorthy
Copy link
Collaborator

@navin-moorthy navin-moorthy commented Sep 29, 2020 •
edited
Loading

  • Removed getCellDateProps() & moved everything to Calendar Cell
  • Above change reduces lot of lines of code
  • Fixed " " - OnKeyDown issue with preventDefault on top.
  • Renamed CalendarRangeState to RangeCalendarState.
  • Removed RangeCalendar because that is Calendar Grid === getCalendarBody(Aria's)
  • Updated Controllable Storybook Examples
  • Fixed styles for wrong data-attributes selectors
  • Updated Announcer for normal Calendar as well

@navin-moorthy navin-moorthy added the enhancements 📈 Improve an existing Feature label Sep 29, 2020
@navin-moorthy navin-moorthy self-assigned this Sep 29, 2020
@anuraghazra anuraghazra merged commit 2b7c5f6 into range-calendar Sep 30, 2020
@navin-moorthy navin-moorthy deleted the range-calendar-v1 branch September 30, 2020 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraghazra anuraghazra anuraghazra left review comments

Assignees

@navin-moorthy navin-moorthy

Labels
enhancements 📈 Improve an existing Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@navin-moorthy @anuraghazra