Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON order has no effect on component output #985

Closed
oliverfoster opened this issue Mar 1, 2016 · 2 comments
Closed

JSON order has no effect on component output #985

oliverfoster opened this issue Mar 1, 2016 · 2 comments
Labels
bug
Milestone
v2.0.8

Comments

@oliverfoster
Copy link
Member

https://github.com/adaptlearning/adapt_framework/blame/master/src/core/js/models/adaptModel.js#L194-L201

this code breaks the assumption that the order of the json determines the order of the render. this is especially problematic when a right-hand graphic aside should appear above its sibling on mobile.
@oliverfoster oliverfoster changed the title JSON order has not effect on component output JSON order has no effect on component output Mar 1, 2016
@tomgreenfield
Copy link
Contributor

Older reference: #636.

@oliverfoster
Copy link
Member Author

#987 pr to fix

@guywillis guywillis mentioned this issue Mar 8, 2016
Merged
@moloko moloko added this to the v2.0.8 milestone Mar 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.0.8
Development

No branches or pull requests
4 participants
@tomgreenfield @moloko @himanshu1618 @oliverfoster