Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose framework version in DOM #2143

Closed
tomgreenfield opened this issue Jun 21, 2018 · 2 comments
Closed

Expose framework version in DOM #2143

tomgreenfield opened this issue Jun 21, 2018 · 2 comments

Comments

@tomgreenfield
Copy link
Contributor

tomgreenfield commented Jun 21, 2018 •
edited
Loading

Suggest exposing the framework version as a data attribute:

<html data-adapt-framework-version="3.1.0">

This would allow us, amongst other things, to style specific versions of framework. For example, the CSS selector for v3.x would be:

[data-adapt-framework-version^="3"]

Inspired by adaptlearning/adapt_authoring#1944.
@oliverfoster
Copy link
Member

:O

@NayanKhedkar NayanKhedkar mentioned this issue Jun 22, 2018
Merged
@NayanKhedkar
Copy link
Member

PR:#2144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tomgreenfield @oliverfoster @NayanKhedkar