Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt has no 'dir' attribute #2033

Closed
moloko opened this issue Apr 9, 2018 · 4 comments
Closed

Adapt has no 'dir' attribute #2033

moloko opened this issue Apr 9, 2018 · 4 comments
Assignees
@moloko

Comments

@moloko
Copy link
Contributor

moloko commented Apr 9, 2018 •
edited
Loading

if we're setting the lang attribute we should really set dir as well for completeness
@moloko moloko self-assigned this Apr 9, 2018
@lc-thomasberger
Copy link
Member

do you mean the name for the subfolder? eg. course/en/... | course/de/...

@moloko
Copy link
Contributor Author

moloko commented Apr 9, 2018

nope I mean <html lang="en" dir="ltr">

@lc-thomasberger
Copy link
Member

nevermind, then a +1 for this issue 😄

@moloko moloko mentioned this issue Apr 9, 2018
Merged
@moloko
Copy link
Contributor Author

moloko commented Apr 9, 2018

cool - have also just done PR on spoor for completeness

@moloko moloko mentioned this issue Apr 9, 2018
Merged
@moloko moloko closed this as completed Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moloko moloko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moloko @lc-thomasberger