startController classname

[danielghost]

https://github.com/adaptlearning/adapt_framework/blob/master/src/core/js/startController.js#L73 - expects a selector rather than a classname, so we may wish to either amend the _className attribute to make this clearer or amend the method to look at classes specifically.

[NayanKhedkar]

@danielghost could you please elaborate more?

[oliverfoster]

http://api.jquery.com/is/ uses a css selector tagName.className#id[name=value] the attribute is called _className even though it's not a class name, it's a selector.
@danielghost is making a point about the clarity of the variable name because he and I struggled to set it up correctly without reading the code.

we either need to change the name to _selector or change the code to $html.hasClass(className) really
i quite like @tomgreenfield suggestion #1858 (comment)

[NayanKhedkar]

Here we provided _className with dot(.) prefix i.e. "_className": ".size-small.touch, .size-medium.touch".
So we can not go for $html.hasClass(className) and also we can't provide multiple classes to hasClass().need to be change documentation also.
What would you prefer @oliverfoster ?

[oliverfoster]

hasClass doesn't allow for and/or style rules.
So you can't do .size-small.touch, .size-medium.touch which is (size-small && touch) || (size-medium && touch).
I like Tom's suggestion in that it allows the expected behaviour for "className" as well as allowing selectors, with one variable. It make sense because it's simple and satisfies all the requirements with the minimal amount of effort.

var $html = $("html");

if (!className || $html.is(className) || $html.hasClass(className)) {

[NayanKhedkar]

Ok that's fine @oliverfoster

[NayanKhedkar]

PR:#1865

[sarveshwar-gavhane]

can some one close this issue ?

[oliverfoster]

👍