Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version must be valid css-class #1402

Closed
lc-thomasberger opened this issue Jan 30, 2017 · 3 comments
Closed

version must be valid css-class #1402

lc-thomasberger opened this issue Jan 30, 2017 · 3 comments
Assignees

Comments

@lc-thomasberger
Copy link
Member

lc-thomasberger commented Jan 30, 2017

https://github.com/adaptlearning/adapt_framework/blob/master/src/core/js/device.js#L192

make sure that versions are added as a valid css-class (no . as delimiters) so that they can be used in css for styling.

E.g. Version-8.0 --> Version-8-0

@lc-thomasberger lc-thomasberger self-assigned this Jan 30, 2017
@oliverfoster
Copy link
Member

all the classes should be lowercase also

@lc-thomasberger
Copy link
Member Author

this might break existing themes though @oliverfoster

@moloko
Copy link
Contributor

moloko commented Mar 27, 2017

done in ca59e7a

@moloko moloko closed this as completed Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants